Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHATX-1247: Refactor Download Transcript #46

Merged
merged 3 commits into from
Mar 30, 2022
Merged

CHATX-1247: Refactor Download Transcript #46

merged 3 commits into from
Mar 30, 2022

Conversation

michaellazz
Copy link
Contributor

@michaellazz michaellazz commented Mar 25, 2022 •
edited
Loading

Description

iOS 14.5 and Greater

  • Using WKDownloadDelegate to capture download and begin standard download in iOS

iOS 14.4 and Older

  • Using regular navigation method to capture navigation to transcript file and pass to downloadUrl() function built for original download transcript solution

Checklist

  • The steps for distribution have been follow here.
  • A Release Note has been drafted and published after merging to master.
  • PR has been labelled with its impact level

@michaellazz michaellazz changed the title Older iOS download handling CHATX-1247: Refactor Download Transcript Mar 25, 2022
@michaellazz michaellazz requested review from andpoke, abhi-ada and a team March 25, 2022 18:39
@pull-request-size pull-request-size bot added size/M and removed size/L labels Mar 25, 2022
@michaellazz michaellazz merged commit 28ab4fa into master Mar 30, 2022
@michaellazz michaellazz deleted the CHATX-1247-Download-Transcript-React-Native branch March 30, 2022 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wole-ada wole-ada wole-ada approved these changes

@abhi-ada abhi-ada abhi-ada approved these changes

@andpoke andpoke Awaiting requested review from andpoke

Assignees
No one assigned
Labels
Impact - L2 size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaellazz @wole-ada @abhi-ada