-
-
Notifications
You must be signed in to change notification settings - Fork 99
Cookie Validation Issue #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thank you very much, I found the code, but my computer does not have vscode installed, how can I compile it? |
The Build Instructions are here. I use Visual Studio 2022 for building, community edition should be sufficient. |
Thank you, I used the donet command line to build, Visual Studio is too big |
I have the same error but where can i put the code into? I don't have the file on my PC in the folder? |
Could you perhaps post a step-by-step explanation of exactly how you did this? |
Will be fixed when I have time. |
looks like once I figured out my issue I have the same issue |
This is the earliest I've been to a bug 😅 cool fix though! |
#262 appears to include a fix for this as well, by changing line 29 to instead read CookieCollection cookies = cookieContainer.GetAllCookies(); The filter implementation is inefficient (it uses a nested loop where a |
If you don't mind how do we add your code to the existing one? |
As has been commented already, the repository includes build instructions. You will need to clone the repository, make the one-line edit, and compile the project. If you don't understand how to do that, you are very unlikely to have the tools necessary, which will only complicate matters. If you are able to make the edits yourself, it is strongly recommended that you do so, for the sake of security. If you are not able to make the edits yourself, you may instead download a fixed copy that I compiled for 64-bit windows and replace the original. The linked copy has only the change outlined here, and does not contain a If you are not able to make the required change and recompile and you are not willing to use my pre-compiled version with the fix, please do not ask how to make the edit yourself. Teaching you how to clone and compile source code is well beyond the scope of a github issue. The developer knows what needs to be fixed and will get to it when they have the opportunity. |
@PrincessRTFM your fixed copy works perfectly! Many thanks! ❤ |
Thank you so much! |
Your link works, thank you so much! I think I understood the instructions and made the clone/edits myself. |
I cloned the master repo with GH Desktop, set the current branch to the PR with the cookie fix, changed the build type from debug to release, built the app solution, went to the bin folder and then ran it without any errors throwing. Thanks! |
Fixed in Release 29 |
It appears that Patron has changed the domain for
session_id
cookie, so the validator is failing to findsession_id
and erroring. Session id is now usingwww.patreon.com
on my end instead of.patreon.com
like all the other cookies.2025-03-14 15:25:40.1908 FATAL [PatreonDownloader.App.Program] Fatal error, application will be closed: UniversalDownloaderPlatform.Common.Exceptions.CookieValidationException: session_id cookie not found at PatreonDownloader.Implementation.PatreonCookieValidator.ValidateCookies(CookieContainer cookieContainer) in M:\Downloaders\PatreonDownloader\Dev\PatreonDownloader.Implementation\PatreonCookieValidator.cs:line 34 at UniversalDownloaderPlatform.Engine.UniversalDownloader.Download(String url, IUniversalDownloaderPlatformSettings settings) in M:\Downloaders\PatreonDownloader\Dev\submodules\UniversalDownloaderPlatform\UniversalDownloaderPlatform.Engine\UniversalDownloader.cs:line 181 at PatreonDownloader.App.Program.RunPatreonDownloader(CommandLineOptions commandLineOptions) in M:\Downloaders\PatreonDownloader\Dev\PatreonDownloader.App\Program.cs:line 128 at PatreonDownloader.App.Program.Main(String[] args) in M:\Downloaders\PatreonDownloader\Dev\PatreonDownloader.App\Program.cs:line 68
Here is a view of the SQLite db for my instance of Chrome that the downloader is managing.

The fix (while maintaining the validation check), would be to just combine the cookies for the two domains before validating.
In
PatreonDownloader.Implementation\PatreonCookieValidator.cs
I just added the one line below to combine the two domains cookie sets before the validation check.Doing the above fixes the issue on my end and the downloader is working fine after that.
The text was updated successfully, but these errors were encountered: