-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: 🔖 Bump version to 1.0.2
#1432
Conversation
This commit updates the dependencies for Docker actions, including types-setuptools, docker/build-push-action, docker/login-action, docker/setup-buildx-action, and docker/metadata-action. The updates include version upgrades and digest changes.
Review changes with SemanticDiff. Analyzed 3 of 6 files.
|
Reviewer's Guide by SourceryThis pull request updates the Docker build-push-action to a newer version and increments the project version from 1.0.1 to 1.0.2. The changes are straightforward and involve modifying the version strings in the respective files. File-Level Changes
Tips
|
Phylum OSS Supply Chain Risk Analysis - FAILEDThis repository analyzes the risk of new dependencies. An If you see this comment, one or more dependencies have failed Phylum's risk analysis. Package:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Anselmoo - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
@@ -69,7 +69,7 @@ jobs: | |||
# https://github.com/docker/build-push-action | |||
- name: Build and push Docker image | |||
id: build-and-push | |||
uses: docker/build-push-action@1ca370b3a9802c92e886402e0dd88098a2533b12 | |||
uses: docker/build-push-action@5176d81f87c23d6fc96624dfdbcd9f3830bbe445 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Consider using a version tag instead of a commit hash for the docker/build-push-action.
Using a version tag (e.g., @v4) instead of a specific commit hash can make it easier to manage and update the action in the future. It also ensures you're using a stable, tagged release.
uses: docker/build-push-action@5176d81f87c23d6fc96624dfdbcd9f3830bbe445 | |
uses: docker/build-push-action@v4 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1432 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 44 44
Lines 4467 4467
=========================================
Hits 4467 4467
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
All PR-Submissions:
Pull Requests for the same
update/change?
New ✨✨ Feature-Submissions:
Changes to ⚙️ Core-Features:
us to include them?
Summary by Sourcery
Bumped project version to 1.0.2 and updated the Docker build-push-action in the GitHub Actions workflow.