Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: 🔖 Bump version to 1.0.2 #1432

Merged
merged 7 commits into from
Jul 27, 2024
Merged

build: 🔖 Bump version to 1.0.2 #1432

merged 7 commits into from
Jul 27, 2024

Conversation

Anselmoo
Copy link
Owner

@Anselmoo Anselmoo commented Jul 27, 2024

All PR-Submissions:


  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open
    Pull Requests for the same
    update/change?

New ✨✨ Feature-Submissions:


  • Does your submission pass tests?
  • Have you lint your code locally prior to submission? Fixed:
  • This PR is for a new feature, not a bug fix.

Changes to ⚙️ Core-Features:


  • Have you added an explanation of what your changes do and why you'd like
    us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

Summary by Sourcery

Bumped project version to 1.0.2 and updated the Docker build-push-action in the GitHub Actions workflow.

  • Build:
    • Updated Docker build-push-action to a new commit hash in the GitHub Actions workflow.

renovate bot and others added 5 commits July 27, 2024 12:28
This commit updates the dependencies for Docker actions, including types-setuptools, docker/build-push-action, docker/login-action, docker/setup-buildx-action, and docker/metadata-action. The updates include version upgrades and digest changes.
Copy link

semanticdiff-com bot commented Jul 27, 2024

Review changes with SemanticDiff.

Analyzed 3 of 6 files.

Filename Status
poetry.lock Unsupported file format
pyproject.toml Unsupported file format
✔️ vendor/docker-stacks Analyzed
✔️ vendor/lmfit-py Analyzed
✔️ spectrafit/__init__.py Analyzed
.github/workflows/docker-cd.yml Unsupported file format

@Anselmoo Anselmoo enabled auto-merge July 27, 2024 10:45
Copy link
Contributor

sourcery-ai bot commented Jul 27, 2024

Reviewer's Guide by Sourcery

This pull request updates the Docker build-push-action to a newer version and increments the project version from 1.0.1 to 1.0.2. The changes are straightforward and involve modifying the version strings in the respective files.

File-Level Changes

Files Changes
.github/workflows/docker-cd.yml
spectrafit/__init__.py
Updated the Docker build-push-action version and bumped the project version to 1.0.2.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

phylum-io bot commented Jul 27, 2024

Phylum OSS Supply Chain Risk Analysis - FAILED

This repository analyzes the risk of new dependencies. An
administrator of this repository has set requirements via Phylum policy.

If you see this comment, one or more dependencies have failed Phylum's risk analysis.

Package: [email protected] failed.

[email protected] contains suspicious behavior in the setup.py.

Risk Domain: Malicious Code
Risk Level: low

Reason: Install Code Execution (Suspicious)

Package: [email protected] failed.

[email protected] contains suspicious behavior in the setup.py.

Risk Domain: Malicious Code
Risk Level: low

Reason: Install Code Execution (Suspicious)

Package: [email protected] failed.

[email protected] contains suspicious behavior in the setup.py.

Risk Domain: Malicious Code
Risk Level: low

Reason: Install Code Execution (Suspicious)

Package: [email protected] failed.

[email protected] contains suspicious behavior in the setup.py.

Risk Domain: Malicious Code
Risk Level: medium

Reason: Install Code Execution (Suspicious)

Package: [email protected] failed.

[email protected] contains suspicious behavior in the setup.py.

Risk Domain: Malicious Code
Risk Level: low

Reason: Install Code Execution (Suspicious)

View this project in the Phylum UI

@github-actions github-actions bot added maintenance Maintenance & Security dependencies Pull requests that update a dependency file github-actions Pull requests that update Github_actions code python Pull requests that update Python code vendor Add or modifying the vendor lib release Release root labels Jul 27, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Anselmoo - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@@ -69,7 +69,7 @@ jobs:
# https://github.com/docker/build-push-action
- name: Build and push Docker image
id: build-and-push
uses: docker/build-push-action@1ca370b3a9802c92e886402e0dd88098a2533b12
uses: docker/build-push-action@5176d81f87c23d6fc96624dfdbcd9f3830bbe445
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Consider using a version tag instead of a commit hash for the docker/build-push-action.

Using a version tag (e.g., @v4) instead of a specific commit hash can make it easier to manage and update the action in the future. It also ensures you're using a stable, tagged release.

Suggested change
uses: docker/build-push-action@5176d81f87c23d6fc96624dfdbcd9f3830bbe445
uses: docker/build-push-action@v4

Copy link

codecov bot commented Jul 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4c821d8) to head (cae49e9).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1432   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           44        44           
  Lines         4467      4467           
=========================================
  Hits          4467      4467           
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
spectrafit/__init__.py 100.00% <100.00%> (ø)

Copy link

@Anselmoo Anselmoo merged commit baf5e69 into main Jul 27, 2024
48 of 49 checks passed
@Anselmoo Anselmoo deleted the feature/updates branch July 27, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file github-actions Pull requests that update Github_actions code maintenance Maintenance & Security python Pull requests that update Python code release Release root vendor Add or modifying the vendor lib
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant