-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: 🔖 update version to v1.0.3
#1443
Conversation
Update docker-cd.yml to build and push images for `linux/amd64` and `linux/arm64` platforms
Review changes with SemanticDiff. Analyzed 1 of 4 files.
|
Reviewer's Guide by SourceryThis pull request updates the project version to 1.0.3. It includes changes to the GitHub Actions workflow by updating dependencies and modifying the platforms list for Docker builds. Additionally, the version number in the project's init.py file has been incremented. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Anselmoo - I've reviewed your changes - here's some feedback:
Overall Comments:
- Could you please explain the rationale behind removing the 'linux/arm/v7' platform from the build process? This change might affect users on older ARM devices.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1443 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 44 44
Lines 4467 4467
=========================================
Hits 4467 4467
Flags with carried forward coverage won't be shown. Click here to find out more.
|
All PR-Submissions:
Pull Requests for the same
update/change?
New ✨✨ Feature-Submissions:
Changes to ⚙️ Core-Features:
us to include them?
Summary by Sourcery
This pull request updates the project version to v1.0.3, modifies the GitHub Actions workflow to use newer versions of the checkout and Docker build-push actions, and removes support for the linux/arm/v7 platform in the Docker build.