Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: 🔖 update version to v1.0.3 #1443

Merged
merged 4 commits into from
Jul 28, 2024
Merged

build: 🔖 update version to v1.0.3 #1443

merged 4 commits into from
Jul 28, 2024

Conversation

Anselmoo
Copy link
Owner

@Anselmoo Anselmoo commented Jul 28, 2024

All PR-Submissions:


  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open
    Pull Requests for the same
    update/change?

New ✨✨ Feature-Submissions:


  • Does your submission pass tests?
  • Have you lint your code locally prior to submission? Fixed:
  • This PR is for a new feature, not a bug fix.

Changes to ⚙️ Core-Features:


  • Have you added an explanation of what your changes do and why you'd like
    us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

Summary by Sourcery

This pull request updates the project version to v1.0.3, modifies the GitHub Actions workflow to use newer versions of the checkout and Docker build-push actions, and removes support for the linux/arm/v7 platform in the Docker build.

  • Build:
    • Updated GitHub Actions checkout action to version 3.6.0.
    • Updated Docker build-push-action to version 4.2.1.
    • Removed support for linux/arm/v7 platform in Docker build.

@Anselmoo Anselmoo enabled auto-merge July 28, 2024 11:11
Copy link

semanticdiff-com bot commented Jul 28, 2024

Review changes with SemanticDiff.

Analyzed 1 of 4 files.

Filename Status
poetry.lock Unsupported file format
pyproject.toml Unsupported file format
✔️ spectrafit/__init__.py Analyzed
.github/workflows/docker-cd.yml Unsupported file format

Copy link
Contributor

sourcery-ai bot commented Jul 28, 2024

Reviewer's Guide by Sourcery

This pull request updates the project version to 1.0.3. It includes changes to the GitHub Actions workflow by updating dependencies and modifying the platforms list for Docker builds. Additionally, the version number in the project's init.py file has been incremented.

File-Level Changes

Files Changes
.github/workflows/docker-cd.yml Updated GitHub Actions workflow dependencies and modified the platforms list for Docker builds.
spectrafit/__init__.py Incremented the project version number to 1.0.3.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

@github-actions github-actions bot added maintenance Maintenance & Security dependencies Pull requests that update a dependency file github-actions Pull requests that update Github_actions code python Pull requests that update Python code release Release root labels Jul 28, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Anselmoo - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Could you please explain the rationale behind removing the 'linux/arm/v7' platform from the build process? This change might affect users on older ARM devices.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Copy link

Copy link

codecov bot commented Jul 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (56ea26e) to head (2cc1c90).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1443   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           44        44           
  Lines         4467      4467           
=========================================
  Hits          4467      4467           
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
spectrafit/__init__.py 100.00% <100.00%> (ø)

@Anselmoo Anselmoo merged commit f9e9e1c into main Jul 28, 2024
48 checks passed
@Anselmoo Anselmoo deleted the feature/fix-docker branch July 28, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file github-actions Pull requests that update Github_actions code maintenance Maintenance & Security python Pull requests that update Python code release Release root
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant