-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: 💚 Update Docker actions #1453
Conversation
…in branch and latest tag
Update pre-commit package to version 3.8.0 and setuptools package to version 72.0.0
Review changes with SemanticDiff. Analyzed 1 of 4 files.
|
Reviewer's Guide by SourceryThis pull request updates the Docker actions by changing the tagging strategy to use PEP 440 versioning with a 'v' prefix. Additionally, the package version in 'spectrafit/init.py' has been incremented from 1.0.3.post0 to 1.0.3.post1. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Anselmoo - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider keeping the 'latest' tag in addition to the new PEP 440 versioning scheme. This would maintain backward compatibility for existing workflows while also providing more precise versioning.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1453 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 44 44
Lines 4467 4467
=========================================
Hits 4467 4467
Flags with carried forward coverage won't be shown. Click here to find out more.
|
All PR-Submissions:
Pull Requests for the same
update/change?
New ✨✨ Feature-Submissions:
Changes to ⚙️ Core-Features:
us to include them?
Note:
Summary by Sourcery
This pull request updates the Docker action for tagging images to use PEP 440 compliant versioning and increments the project version. Additionally, it updates the pre-commit and setuptools packages to their latest versions.