Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 💚 Update dependencies to latest versions #1457

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

Anselmoo
Copy link
Owner

@Anselmoo Anselmoo commented Jul 29, 2024

Update dash-bootstrap-templates to version 1.2.3, setuptools to version 72.1.0, and tenacity to version 9.0.0. Also update the project version to 1.0.3.post2.

All PR-Submissions:


  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open
    Pull Requests for the same
    update/change?

New ✨✨ Feature-Submissions:


  • Does your submission pass tests?
  • Have you lint your code locally prior to submission? Fixed:
  • This PR is for a new feature, not a bug fix.

Changes to ⚙️ Core-Features:


  • Have you added an explanation of what your changes do and why you'd like
    us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

Summary by Sourcery

This pull request updates several dependencies to their latest versions, comments out the tags configuration in the CI workflow, and increments the project version to 1.0.3.post2.

  • Build:
    • Updated dash-bootstrap-templates to version 1.2.3, setuptools to version 72.1.0, and tenacity to version 9.0.0.
  • CI:
    • Commented out the tags configuration in the docker-cd.yml workflow file.
  • Chores:
    • Updated the project version to 1.0.3.post2.

Anselmoo added 2 commits July 29, 2024 18:52
Update dash-bootstrap-templates to version 1.2.3, setuptools to version 72.1.0, and tenacity to version 9.0.0. Also update the project version to 1.0.3.post2.
@Anselmoo Anselmoo enabled auto-merge (squash) July 29, 2024 16:57
Copy link

semanticdiff-com bot commented Jul 29, 2024

Review changes with SemanticDiff.

Analyzed 1 of 4 files.

Filename Status
poetry.lock Unsupported file format
pyproject.toml Unsupported file format
✔️ spectrafit/__init__.py Analyzed
.github/workflows/docker-cd.yml Unsupported file format

Copy link
Contributor

sourcery-ai bot commented Jul 29, 2024

Reviewer's Guide by Sourcery

This pull request updates several dependencies to their latest versions: dash-bootstrap-templates to 1.2.3, setuptools to 72.1.0, and tenacity to 9.0.0. Additionally, it updates the project version to 1.0.3.post2 and comments out the tags configuration in the Docker CD workflow.

File-Level Changes

Files Changes
.github/workflows/docker-cd.yml
spectrafit/__init__.py
Updated dependencies and project version, and commented out the tags configuration in the Docker CD workflow.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

@github-actions github-actions bot added maintenance Maintenance & Security dependencies Pull requests that update a dependency file github-actions Pull requests that update Github_actions code python Pull requests that update Python code release Release root labels Jul 29, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Anselmoo - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Could you please explain why the tags section in the docker-cd.yml file has been commented out? This change might affect the versioning of Docker images and could have unintended consequences for the CI/CD pipeline.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Copy link

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (89dbd0c) to head (9c9d32c).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1457   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           44        44           
  Lines         4467      4467           
=========================================
  Hits          4467      4467           
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
spectrafit/__init__.py 100.00% <100.00%> (ø)

@Anselmoo Anselmoo merged commit 73097ff into main Jul 29, 2024
49 checks passed
@Anselmoo Anselmoo deleted the feature/docker-std-fix branch July 29, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file github-actions Pull requests that update Github_actions code maintenance Maintenance & Security python Pull requests that update Python code release Release root
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant