Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: 🗂️ Changlog update for 1.0.3.post2 #1458

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Conversation

Anselmoo
Copy link
Owner

@Anselmoo Anselmoo commented Jul 29, 2024

This is an auto-generated pull request to merge release/1.0.3.post2 with Changelog updates to main.

Summary by Sourcery

This pull request updates the CHANGELOG.md file to document the changes and updates introduced in version 1.0.3.post2, including maintenance tasks, dependency updates, and contributions.

  • Documentation:
    • Updated CHANGELOG.md to include details for version 1.0.3.post2, highlighting maintenance updates, dependency updates, and contributions.

@Anselmoo Anselmoo enabled auto-merge (rebase) July 29, 2024 17:11
Copy link

Review changes with SemanticDiff.

Copy link
Contributor

sourcery-ai bot commented Jul 29, 2024

Reviewer's Guide by Sourcery

This pull request updates the CHANGELOG.md file to document the changes introduced in version 1.0.3.post2. The changes include updates on maintenance, Python dependencies, GitHub Actions, and a full changelog link.

File-Level Changes

Files Changes
CHANGELOG.md Updated the changelog to include details for version 1.0.3.post2, covering maintenance, Python dependencies, GitHub Actions, and a link to the full changelog.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Anselmoo - I've reviewed your changes - here's some feedback:

Overall Comments:

  • There's a discrepancy between the version number in the changelog (1.0.3.post2) and the one in the full changelog link (1.0.4). Please ensure these are consistent to avoid confusion.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟡 Documentation: 2 issues found

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

CHANGELOG.md Outdated

#### :memo: Changelog

* docs: :card_index_dividers: Changlog update for v1.0.3.post1 (#1454) @Anselmoo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (documentation): Typo in 'Changlog'

It looks like there's a typo in 'Changlog'. It should be 'Changelog'.


**Full Changelog**: https://github.com/Anselmoo/spectrafit/compare/v1.0.3.post1...v1.0.4

### :gear: Who Contributes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (documentation): Rephrase 'Who Contributes'

Consider rephrasing 'Who Contributes' to 'Contributors' for better clarity.

Suggested change
### :gear: Who Contributes
### :gear: Contributors

Copy link

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (73097ff) to head (6fcc632).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1458   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           44        44           
  Lines         4467      4467           
=========================================
  Hits          4467      4467           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Anselmoo Anselmoo merged commit bf6741c into main Jul 29, 2024
48 checks passed
@Anselmoo Anselmoo deleted the release/1.0.3.post2 branch July 29, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant