-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: 🗂️ Changlog update for 1.0.3.post2 #1458
Conversation
Review changes with SemanticDiff. |
Reviewer's Guide by SourceryThis pull request updates the CHANGELOG.md file to document the changes introduced in version 1.0.3.post2. The changes include updates on maintenance, Python dependencies, GitHub Actions, and a full changelog link. File-Level Changes
Tips
|
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Anselmoo - I've reviewed your changes - here's some feedback:
Overall Comments:
- There's a discrepancy between the version number in the changelog (1.0.3.post2) and the one in the full changelog link (1.0.4). Please ensure these are consistent to avoid confusion.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 2 issues found
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
CHANGELOG.md
Outdated
|
||
#### :memo: Changelog | ||
|
||
* docs: :card_index_dividers: Changlog update for v1.0.3.post1 (#1454) @Anselmoo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (documentation): Typo in 'Changlog'
It looks like there's a typo in 'Changlog'. It should be 'Changelog'.
|
||
**Full Changelog**: https://github.com/Anselmoo/spectrafit/compare/v1.0.3.post1...v1.0.4 | ||
|
||
### :gear: Who Contributes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (documentation): Rephrase 'Who Contributes'
Consider rephrasing 'Who Contributes' to 'Contributors' for better clarity.
### :gear: Who Contributes | |
### :gear: Contributors |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1458 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 44 44
Lines 4467 4467
=========================================
Hits 4467 4467
Flags with carried forward coverage won't be shown. Click here to find out more. |
This is an auto-generated pull request to merge release/1.0.3.post2 with Changelog updates to main.
Summary by Sourcery
This pull request updates the CHANGELOG.md file to document the changes and updates introduced in version 1.0.3.post2, including maintenance tasks, dependency updates, and contributions.