-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: 🧪 Update weekly-poetry-bot.yml workflow schedule for testing #1484
Conversation
Review changes with SemanticDiff. |
Reviewer's Guide by SourceryThis pull request updates the 'weekly-poetry-bot.yml' workflow file. The main changes include modifying the schedule to run every hour for testing, adding write permissions for contents and pull-requests, and replacing the auto-merge action with a new step that uses the 'gh' CLI to automatically merge pull requests. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Anselmoo - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider explicitly setting the merge strategy in the
gh pr merge
command if you have a preferred method (e.g., --squash, --merge, or --rebase). - The hourly cron schedule (
0 0 * * *
) seems frequent for a production setting. Ensure this is changed back to a more appropriate interval before merging to the main branch.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1484 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 44 44
Lines 4467 4467
=========================================
Hits 4467 4467
Flags with carried forward coverage won't be shown. Click here to find out more. |
All PR-Submissions:
Pull Requests for the same
update/change?
New ✨✨ Feature-Submissions:
Changes to ⚙️ Core-Features:
us to include them?
Summary by Sourcery
Update the weekly-poetry-bot.yml workflow to run more frequently for testing, adjust permissions, and replace the automerge action with a custom GitHub CLI script for auto PR merging.
CI: