Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 🧪 Update weekly-poetry-bot.yml workflow schedule for testing #1484

Merged
merged 2 commits into from
Aug 11, 2024

Conversation

Anselmoo
Copy link
Owner

@Anselmoo Anselmoo commented Aug 11, 2024

All PR-Submissions:


  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open
    Pull Requests for the same
    update/change?

New ✨✨ Feature-Submissions:


  • Does your submission pass tests?
  • Have you lint your code locally prior to submission? Fixed:
  • This PR is for a new feature, not a bug fix.

Changes to ⚙️ Core-Features:


  • Have you added an explanation of what your changes do and why you'd like
    us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

Summary by Sourcery

Update the weekly-poetry-bot.yml workflow to run more frequently for testing, adjust permissions, and replace the automerge action with a custom GitHub CLI script for auto PR merging.

CI:

  • Update the schedule of the weekly-poetry-bot.yml workflow to run every hour for testing purposes.
  • Modify permissions in the workflow to include write access for contents and pull-requests.
  • Replace the automerge action with a custom script to set auto PR merging using GitHub CLI.

@Anselmoo Anselmoo enabled auto-merge August 11, 2024 05:37
Copy link

Review changes with SemanticDiff.

Copy link
Contributor

sourcery-ai bot commented Aug 11, 2024

Reviewer's Guide by Sourcery

This pull request updates the 'weekly-poetry-bot.yml' workflow file. The main changes include modifying the schedule to run every hour for testing, adding write permissions for contents and pull-requests, and replacing the auto-merge action with a new step that uses the 'gh' CLI to automatically merge pull requests.

File-Level Changes

Files Changes
.github/workflows/weekly-poetry-bot.yml Updated the workflow schedule to run hourly for testing, added necessary permissions, and replaced the auto-merge step with a new implementation using the 'gh' CLI.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

@github-actions github-actions bot added the github-actions Pull requests that update Github_actions code label Aug 11, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Anselmoo - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider explicitly setting the merge strategy in the gh pr merge command if you have a preferred method (e.g., --squash, --merge, or --rebase).
  • The hourly cron schedule (0 0 * * *) seems frequent for a production setting. Ensure this is changed back to a more appropriate interval before merging to the main branch.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Copy link

Copy link

codecov bot commented Aug 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (45f3489) to head (4b428b5).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1484   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           44        44           
  Lines         4467      4467           
=========================================
  Hits          4467      4467           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Anselmoo Anselmoo merged commit 4c24c81 into main Aug 11, 2024
33 checks passed
@Anselmoo Anselmoo deleted the fix/automerge branch August 11, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-actions Pull requests that update Github_actions code size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant