-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update weekly-poetry-bot.yml #1485
Conversation
Review changes with SemanticDiff. |
Reviewer's Guide by SourceryThis pull request updates the schedule for the weekly-poetry-bot workflow to run every hour for testing purposes. The change is implemented by modifying the cron expression in the YAML configuration file. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Anselmoo - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider reducing the frequency of the cron job for testing (e.g., every 6 or 12 hours instead of every hour) to avoid potential rate limiting issues.
- Add a comment in the workflow file explaining the reason for the more frequent schedule and how long it's expected to remain in place.
- Keep both the original weekly schedule and the new testing schedule in the file (with one commented out) for easier switching between production and testing configurations.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1485 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 44 44
Lines 4467 4467
=========================================
Hits 4467 4467
Flags with carried forward coverage won't be shown. Click here to find out more. |
All PR-Submissions:
Pull Requests for the same
update/change?
New ✨✨ Feature-Submissions:
Changes to ⚙️ Core-Features:
us to include them?
Summary by Sourcery
Update the schedule for the weekly-poetry-bot.yml CI workflow to run every hour instead of every day for testing.
CI: