-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ⚡ Allows also empty commits #1487
Conversation
Review changes with SemanticDiff. |
Reviewer's Guide by SourceryThis pull request updates the 'weekly-poetry-bot' GitHub Actions workflow. The cron schedule is changed to run every Sunday at midnight. The 'Update dependencies' step now logs output to 'poetry-update.log'. The 'Create new branch' step is modified to add only 'poetry.lock' and includes logic to create an empty commit if no changes are detected, otherwise, it includes the update log in the commit message. File-Level Changes
Tips
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Anselmoo - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please fill out the PR description template to provide more context about your changes.
- Consider simplifying the log handling. Instead of using
tee
and then reading the file, you could capture the output directly in a variable.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
@@ -30,15 +29,22 @@ jobs: | |||
run: poetry install | |||
|
|||
- name: Update dependencies | |||
run: poetry update | |||
run: poetry update | tee poetry-update.log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (bug_risk): Log file name inconsistency may lead to empty commit messages
The update log is saved as 'poetry-update.log', but later in the script, it's referred to as 'update.log'. This inconsistency could result in empty commit messages as the correct file won't be read.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1487 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 44 44
Lines 4467 4467
=========================================
Hits 4467 4467
Flags with carried forward coverage won't be shown. Click here to find out more. |
All PR-Submissions:
Pull Requests for the same
update/change?
New ✨✨ Feature-Submissions:
Changes to ⚙️ Core-Features:
us to include them?
Summary by Sourcery
Enable empty commits in the weekly Poetry update workflow when no dependency updates are detected, and include update logs in commit messages when updates are present. Revert the cron schedule to run every Sunday at midnight.
New Features:
Enhancements:
CI: