Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 Update poetry-update log file name for commit message #1493

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

Anselmoo
Copy link
Owner

@Anselmoo Anselmoo commented Aug 19, 2024

Update script to use poetry-update.log instead of update.log for tracking dependencies.

All PR-Submissions:


  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open
    Pull Requests for the same
    update/change?

New ✨✨ Feature-Submissions:


  • Does your submission pass tests?
  • Have you lint your code locally prior to submission? Fixed:
  • This PR is for a new feature, not a bug fix.

Changes to ⚙️ Core-Features:


  • Have you added an explanation of what your changes do and why you'd like
    us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

Summary by Sourcery

Fix the log file name in the weekly poetry bot workflow to ensure the correct file is used for commit messages when tracking dependency updates.

Bug Fixes:

  • Correct the log file name used in the commit message from update.log to poetry-update.log in the weekly poetry bot workflow.

Update script to use `poetry-update.log` instead of `update.log` for tracking dependencies.
@Anselmoo Anselmoo enabled auto-merge August 19, 2024 04:18
Copy link

Review changes with SemanticDiff.

Copy link
Contributor

sourcery-ai bot commented Aug 19, 2024

Reviewer's Guide by Sourcery

This pull request updates the weekly-poetry-bot workflow to use a more specific log file name for tracking dependency updates. The change replaces 'update.log' with 'poetry-update.log' in the commit message creation process.

File-Level Changes

Files Changes
.github/workflows/weekly-poetry-bot.yml Updated the log file name from 'update.log' to 'poetry-update.log' for tracking dependency updates
.github/workflows/weekly-poetry-bot.yml Modified the echo message to reflect the use of 'poetry-update.log'

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

@github-actions github-actions bot added the github-actions Pull requests that update Github_actions code label Aug 19, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Anselmoo - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Copy link

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (416e0c5) to head (0608dd8).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1493   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           44        44           
  Lines         4467      4467           
=========================================
  Hits          4467      4467           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Anselmoo Anselmoo merged commit 3d43c2a into main Aug 19, 2024
33 checks passed
@Anselmoo Anselmoo deleted the fix/docker-weekly-update branch August 19, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-actions Pull requests that update Github_actions code size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant