Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove git push #1508

Merged
merged 1 commit into from
Aug 25, 2024
Merged

fix: Remove git push #1508

merged 1 commit into from
Aug 25, 2024

Conversation

Anselmoo
Copy link
Owner

@Anselmoo Anselmoo commented Aug 25, 2024

All PR-Submissions:


  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open
    Pull Requests for the same
    update/change?

New ✨✨ Feature-Submissions:


  • Does your submission pass tests?
  • Have you lint your code locally prior to submission? Fixed:
  • This PR is for a new feature, not a bug fix.

Changes to ⚙️ Core-Features:


  • Have you added an explanation of what your changes do and why you'd like
    us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

Summary by Sourcery

Remove the git push command from the weekly-poetry-bot GitHub Actions workflow to prevent automatic pushing of updates.

CI:

  • Remove the git push command from the weekly-poetry-bot GitHub Actions workflow.

Copy link
Contributor

sourcery-ai bot commented Aug 25, 2024

Reviewer's Guide by Sourcery

This pull request removes the git push command from the weekly poetry bot workflow, likely to prevent automatic pushing of changes to the remote repository.

File-Level Changes

Change Details Files
Removal of automatic git push in the weekly poetry bot workflow
  • Deleted the git push command that was pushing changes to the 'update-dependencies' branch
.github/workflows/weekly-poetry-bot.yml

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

@github-actions github-actions bot added maintenance Maintenance & Security github-actions Pull requests that update Github_actions code root labels Aug 25, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Anselmoo - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Could you please provide more context on why the git push command was removed? We want to ensure this doesn't negatively impact the workflow.
  • Consider updating the PR title to more accurately reflect the nature of the change, e.g., 'refactor: Remove redundant git push command' if that's the case.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Revert "fix: Remove `git push`"

This reverts commit cd31420.

chore(deps): update dependencies in poetry.lock
@Anselmoo Anselmoo force-pushed the fix/worklfow/weekly-2 branch from cd31420 to 813c01c Compare August 25, 2024 10:56
Copy link

Copy link

codecov bot commented Aug 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (70e77d5) to head (813c01c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1508   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           44        44           
  Lines         4466      4466           
=========================================
  Hits          4466      4466           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Anselmoo Anselmoo disabled auto-merge August 25, 2024 11:11
@Anselmoo Anselmoo merged commit f4efe5a into main Aug 25, 2024
32 of 33 checks passed
@Anselmoo Anselmoo deleted the fix/worklfow/weekly-2 branch August 25, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-actions Pull requests that update Github_actions code maintenance Maintenance & Security root size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant