Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 💚 Update GitHub Actions workflow to use 'gh pr merge' command #1528

Merged
merged 2 commits into from
Sep 1, 2024

Conversation

Anselmoo
Copy link
Owner

@Anselmoo Anselmoo commented Sep 1, 2024

All PR-Submissions:


  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open
    Pull Requests for the same
    update/change?

New ✨✨ Feature-Submissions:


  • Does your submission pass tests?
  • Have you lint your code locally prior to submission? Fixed:
  • This PR is for a new feature, not a bug fix.

Changes to ⚙️ Core-Features:


  • Have you added an explanation of what your changes do and why you'd like
    us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

Summary by Sourcery

Update the GitHub Actions workflow to run more frequently for testing, enhance timestamp precision in branch names and commit messages, and adjust the pull request merge strategy to use the '--merge' option.

CI:

  • Update GitHub Actions workflow to run every hour for testing purposes instead of every Sunday at midnight.
  • Modify branch naming and commit messages to include hours and minutes for more precise timestamping.
  • Change the GitHub CLI command to merge pull requests using the '--merge' option instead of '--rebase'.

@Anselmoo Anselmoo enabled auto-merge (rebase) September 1, 2024 06:27
Copy link

Review changes with SemanticDiff.

Copy link
Contributor

sourcery-ai bot commented Sep 1, 2024

Reviewer's Guide by Sourcery

This pull request updates the GitHub Actions workflow for weekly dependency updates. It modifies the cron schedule, changes the branch naming convention, updates commit messages with more precise timestamps, and adjusts the PR creation and merging process.

File-Level Changes

Change Details Files
Modified the cron schedule for the workflow
  • Changed from running every Sunday at midnight to running every hour
  • Added a comment indicating the change is for testing purposes
.github/workflows/weekly-poetry-bot.yml
Updated branch naming and commit message timestamps
  • Added minutes to the branch name for more uniqueness
  • Updated commit messages to include minutes in the timestamp
.github/workflows/weekly-poetry-bot.yml
Modified the Pull Request creation and merging process
  • Updated PR title to include minutes in the timestamp
  • Changed the PR merging step to use 'gh pr merge' command
  • Switched from rebase to merge strategy for PR merging
.github/workflows/weekly-poetry-bot.yml

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

@github-actions github-actions bot added the github-actions Pull requests that update Github_actions code label Sep 1, 2024
@Anselmoo Anselmoo disabled auto-merge September 1, 2024 06:27
@Anselmoo Anselmoo enabled auto-merge (squash) September 1, 2024 06:27
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Anselmoo - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The cron schedule has been changed to run every hour for testing purposes. While this is useful for development, ensure this is changed back to a more appropriate frequency before merging to production to avoid unnecessary PR spam.
  • The PR merging strategy has been changed from rebase to merge. Could you provide the rationale behind this change? Both strategies have their merits, so it would be helpful to understand the reasoning.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Copy link

sonarqubecloud bot commented Sep 1, 2024

Copy link

codecov bot commented Sep 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ced5e88) to head (458fac0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1528   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           44        44           
  Lines         4466      4466           
=========================================
  Hits          4466      4466           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Anselmoo Anselmoo merged commit 0d662ac into main Sep 1, 2024
33 checks passed
@Anselmoo Anselmoo deleted the fix/weekly-update-fix-2 branch September 1, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-actions Pull requests that update Github_actions code size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant