-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 💚 Set branch as env variable #1531
Conversation
Review changes with SemanticDiff. |
Reviewer's Guide by SourceryThis pull request modifies the weekly Poetry update workflow to use an environment variable for the date stamp, adjusts the cron schedule for testing, and updates the commit messages and branch names accordingly. File-Level Changes
Tips
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Anselmoo - I've reviewed your changes - here's some feedback:
Overall Comments:
- The change to run the workflow every minute (cron: '* * * * *') could be problematic if left in production. Consider reverting this change or adding a clear TODO to adjust it before merging to the main branch.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
@@ -2,8 +2,8 @@ name: Weekly Poetry Update | |||
|
|||
on: | |||
schedule: | |||
- cron: '* * * * *' # Runs every time for testing purposes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (performance): Consider adding a TODO comment for reverting the cron schedule
While this frequency is useful for testing, it could have significant performance implications if left in production. Consider adding a TODO or FIXME comment to remind yourself to revert this to a more appropriate schedule before merging to production.
# TODO: Revert to weekly schedule before deploying to production
- cron: '* * * * *' # Runs every minute for testing purposes
# - cron: '0 0 * * 0' # Runs every Sunday at midnight
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1531 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 44 44
Lines 4466 4466
=========================================
Hits 4466 4466
Flags with carried forward coverage won't be shown. Click here to find out more. |
All PR-Submissions:
Pull Requests for the same
update/change?
New ✨✨ Feature-Submissions:
Changes to ⚙️ Core-Features:
us to include them?
Summary by Sourcery
Update the GitHub Actions workflow to use an environment variable for the date in branch names and commit messages, ensuring consistent and maintainable automation.
CI: