Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: ✅ Deactivate auto merge #1542

Merged
merged 1 commit into from
Sep 1, 2024
Merged

ci: ✅ Deactivate auto merge #1542

merged 1 commit into from
Sep 1, 2024

Conversation

Anselmoo
Copy link
Owner

@Anselmoo Anselmoo commented Sep 1, 2024

All PR-Submissions:


  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open
    Pull Requests for the same
    update/change?

New ✨✨ Feature-Submissions:


  • Does your submission pass tests?
  • Have you lint your code locally prior to submission? Fixed:
  • This PR is for a new feature, not a bug fix.

Changes to ⚙️ Core-Features:


  • Have you added an explanation of what your changes do and why you'd like
    us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

Summary by Sourcery

Deactivate the automatic merging of pull requests in the CI workflow by commenting out the merge step in the weekly-poetry-bot configuration.

CI:

  • Deactivate the automatic merging of pull requests in the weekly-poetry-bot workflow by commenting out the relevant steps.

@Anselmoo Anselmoo enabled auto-merge September 1, 2024 14:00
Copy link

Review changes with SemanticDiff.

Copy link
Contributor

sourcery-ai bot commented Sep 1, 2024

Reviewer's Guide by Sourcery

This pull request deactivates the auto-merge functionality in the weekly poetry bot workflow. The change is implemented by commenting out the step that automatically merges the pull request created by the bot.

File-Level Changes

Change Details Files
Deactivation of auto-merge in weekly poetry bot workflow
  • Commented out the 'Merge Pull Request via gh' step
  • Removed the automatic merging of the 'update-dependencies' pull request
  • Preserved the original code as comments for potential future reference or reactivation
.github/workflows/weekly-poetry-bot.yml

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

@github-actions github-actions bot added the github-actions Pull requests that update Github_actions code label Sep 1, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Anselmoo - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Could you please provide some context on why auto-merge for dependency updates is being disabled? Understanding the rationale behind this change would be helpful for the project maintainers and contributors.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Copy link

sonarqubecloud bot commented Sep 1, 2024

Copy link

codecov bot commented Sep 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (592892f) to head (b8c4375).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1542   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           44        44           
  Lines         4466      4466           
=========================================
  Hits          4466      4466           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Anselmoo Anselmoo disabled auto-merge September 1, 2024 14:08
@Anselmoo Anselmoo merged commit e5d1ee7 into main Sep 1, 2024
33 checks passed
@Anselmoo Anselmoo deleted the test/deactive-auto-merge branch September 1, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-actions Pull requests that update Github_actions code size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant