-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: 💚 Add repository_dispatch event to GitHub Actions workflows #1548
Conversation
Review changes with SemanticDiff. |
Reviewer's Guide by SourceryThis pull request enhances the GitHub Actions workflows by adding repository_dispatch events and improving the weekly-poetry-bot workflow. The changes focus on automating the process of updating dependencies, adding labels, and merging pull requests after required checks pass. File-Level Changes
Tips
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Anselmoo - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a brief explanation in the PR description about the motivation for adding the
repository_dispatch
event to the workflows. - Ensure that the
GITHUB_TOKEN
used in the workflows has the necessary permissions and is securely managed. It might be helpful to mention any security considerations in the PR description. - Add comments in the workflow files to explain the purpose of the new
repository_dispatch
event for better documentation and future reference.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
- name: Wait for required checks | ||
run: | | ||
pr_number=$(gh pr view --json number --jq '.number') | ||
gh pr checks --wait $pr_number |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (performance): Add a timeout to the wait for checks command
Consider adding a timeout to this command to prevent the workflow from hanging indefinitely if a check fails or takes too long. For example: gh pr checks --wait $pr_number --timeout 30m
gh pr checks --wait $pr_number | |
gh pr checks --wait $pr_number --timeout 30m |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1548 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 44 44
Lines 4466 4466
=========================================
Hits 4466 4466
Flags with carried forward coverage won't be shown. Click here to find out more. |
All PR-Submissions:
Pull Requests for the same
update/change?
New ✨✨ Feature-Submissions:
Changes to ⚙️ Core-Features:
us to include them?
Summary by Sourcery
Integrate repository_dispatch event into multiple GitHub Actions workflows to allow triggering via external events and enhance the weekly-poetry-bot workflow with additional steps for labeling, checking, and merging pull requests.
CI: