-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: 💚 Update GitHub Actions workflow to include the --fill flag #1553
Conversation
Review changes with SemanticDiff. |
Reviewer's Guide by SourceryThe pull request updates the GitHub Actions workflow by adding the --fill flag to the dependency update process and removing the step that waits for required checks. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Anselmoo - I've reviewed your changes - here's some feedback:
Overall Comments:
- Could you please explain the rationale behind removing the 'Wait for required checks' step? This might potentially lead to merging PRs before all necessary checks have completed.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1553 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 44 44
Lines 4466 4466
=========================================
Hits 4466 4466
Flags with carried forward coverage won't be shown. Click here to find out more. |
All PR-Submissions:
Pull Requests for the same
update/change?
New ✨✨ Feature-Submissions:
Changes to ⚙️ Core-Features:
us to include them?
Summary by Sourcery
Update the GitHub Actions workflow by adding the --fill flag to the weekly-poetry-bot job and removing the step that waits for required checks.
CI: