-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 🌱 Update linting #1592
fix: 🌱 Update linting #1592
Conversation
Review changes with SemanticDiff. |
Reviewer's Guide by SourceryThis pull request updates the linting configuration and makes a minor change to the CHANGELOG.md file. The changes are minimal and focused on improving code quality and consistency. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Anselmoo - I've reviewed your changes - here's some feedback:
Overall Comments:
- Could you provide some context on why the version number format is being changed to include the 'v' prefix? Understanding the motivation behind this change would be helpful.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 1 issue found
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
@@ -143,7 +143,7 @@ https://github.com/Anselmoo/spectrafit/compare/v1.0.3.post2...v1.0.4 | |||
|
|||
@Anselmoo, @github-actions, @github-actions[bot], @renovate and @renovate[bot] | |||
|
|||
## 1.0.3.post2 🌈 - 2024-07-29 | |||
## v1.0.3.post2 🌈 - 2024-07-29 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (documentation): Consider consistency in version number formatting
The addition of 'v' prefix here creates an inconsistency with other version numbers in the changelog. Consider either adding 'v' to all version numbers for consistency, or removing it from this instance.
## v1.0.3.post2 🌈 - 2024-07-29 | |
## 1.0.3.post2 🌈 - 2024-07-29 |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1592 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 44 44
Lines 4466 4466
=========================================
Hits 4466 4466
Flags with carried forward coverage won't be shown. Click here to find out more. |
All PR-Submissions:
Pull Requests for the same
update/change?
New ✨✨ Feature-Submissions:
Changes to ⚙️ Core-Features:
us to include them?
Summary by Sourcery
Correct the version format in the CHANGELOG.md file to ensure consistency with other version entries.
Chores: