Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🌱 Update linting #1592

Merged
merged 1 commit into from
Sep 16, 2024
Merged

fix: 🌱 Update linting #1592

merged 1 commit into from
Sep 16, 2024

Conversation

Anselmoo
Copy link
Owner

@Anselmoo Anselmoo commented Sep 16, 2024

All PR-Submissions:


  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open
    Pull Requests for the same
    update/change?

New ✨✨ Feature-Submissions:


  • Does your submission pass tests?
  • Have you lint your code locally prior to submission? Fixed:
  • This PR is for a new feature, not a bug fix.

Changes to ⚙️ Core-Features:


  • Have you added an explanation of what your changes do and why you'd like
    us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

Summary by Sourcery

Correct the version format in the CHANGELOG.md file to ensure consistency with other version entries.

Chores:

  • Correct the version format in the CHANGELOG.md file from '1.0.3.post2' to 'v1.0.3.post2'.

Copy link

Review changes with SemanticDiff.

Copy link
Contributor

sourcery-ai bot commented Sep 16, 2024

Reviewer's Guide by Sourcery

This pull request updates the linting configuration and makes a minor change to the CHANGELOG.md file. The changes are minimal and focused on improving code quality and consistency.

File-Level Changes

Change Details Files
Updated version number format in CHANGELOG.md
  • Changed '1.0.3.post2' to 'v1.0.3.post2' in the changelog
CHANGELOG.md

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

@Anselmoo Anselmoo changed the title fix: :seed: Update linting fix: 🌱 Update linting Sep 16, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Anselmoo - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Could you provide some context on why the version number format is being changed to include the 'v' prefix? Understanding the motivation behind this change would be helpful.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟡 Documentation: 1 issue found

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@@ -143,7 +143,7 @@ https://github.com/Anselmoo/spectrafit/compare/v1.0.3.post2...v1.0.4

@Anselmoo, @github-actions, @github-actions[bot], @renovate and @renovate[bot]

## 1.0.3.post2 🌈 - 2024-07-29
## v1.0.3.post2 🌈 - 2024-07-29
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (documentation): Consider consistency in version number formatting

The addition of 'v' prefix here creates an inconsistency with other version numbers in the changelog. Consider either adding 'v' to all version numbers for consistency, or removing it from this instance.

Suggested change
## v1.0.3.post2 🌈 - 2024-07-29
## 1.0.3.post2 🌈 - 2024-07-29

Copy link

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (78c4827) to head (fe2b049).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1592   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           44        44           
  Lines         4466      4466           
=========================================
  Hits          4466      4466           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Anselmoo Anselmoo merged commit 54857ab into main Sep 16, 2024
33 checks passed
@Anselmoo Anselmoo deleted the Anselmoo-patch-1 branch September 16, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant