Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ⬆️ update subproject commit for docker-stacks #1651

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Conversation

Anselmoo
Copy link
Owner

@Anselmoo Anselmoo commented Oct 16, 2024

All PR-Submissions:


  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open
    Pull Requests for the same
    update/change?

New ✨✨ Feature-Submissions:


  • Does your submission pass tests?
  • Have you lint your code locally prior to submission? Fixed:
  • This PR is for a new feature, not a bug fix.

Changes to ⚙️ Core-Features:


  • Have you added an explanation of what your changes do and why you'd like
    us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

Summary by Sourcery

Update the type annotation for PYTHON_38_VERSION to use Literal for more precise type checking and bump the project version to 1.0.6.

Enhancements:

  • Update the type annotation for PYTHON_38_VERSION to use Literal for more precise type checking.

Chores:

  • Bump the project version from 1.0.5 to 1.0.6.

@Anselmoo Anselmoo enabled auto-merge (squash) October 16, 2024 04:47
Copy link

semanticdiff-com bot commented Oct 16, 2024

Review changes with SemanticDiff.

Analyzed 3 of 5 files.

Overall, the semantic diff is 24% smaller than the GitHub diff.

Filename Status
poetry.lock Unsupported file format
pyproject.toml Unsupported file format
✔️ vendor/docker-stacks Analyzed
✔️ spectrafit/__init__.py 35.56% smaller
✔️ spectrafit/test/test_init.py Analyzed

Copy link
Contributor

sourcery-ai bot commented Oct 16, 2024

Reviewer's Guide by Sourcery

This pull request updates the spectrafit package version and makes minor changes to improve type hinting in the __init__.py file. The changes are minimal but contribute to better code quality and version management.

Class diagram for updated type hinting in spectrafit

classDiagram
    class spectrafit {
        +tuple[Literal[3], Literal[8]] PYTHON_38_VERSION
        +str __version__
    }
    note for spectrafit "Updated type hint for PYTHON_38_VERSION and version increment"
Loading

File-Level Changes

Change Details Files
Update package version
  • Increment version number from 1.0.5 to 1.0.6
spectrafit/__init__.py
Improve type hinting
  • Import Literal from typing module
  • Add type annotation for PYTHON_38_VERSION constant
spectrafit/__init__.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

phylum-io bot commented Oct 16, 2024

Phylum OSS Supply Chain Risk Analysis - INCOMPLETE

The analysis contains 1 package(s) Phylum has not yet processed,
preventing a complete risk analysis. Phylum is processing these
packages currently and should complete soon.
Please wait for up to 30 minutes, then re-run the analysis.

View this project in the Phylum UI

@github-actions github-actions bot added maintenance Maintenance & Security dependencies Pull requests that update a dependency file python Pull requests that update Python code vendor Add or modifying the vendor lib release Release root labels Oct 16, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Anselmoo - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The pull request description template hasn't been filled out. Please provide more context about the changes by completing the template, which helps reviewers understand the purpose and impact of the modifications.
  • Consider adding a comment explaining the rationale for maintaining Python 3.8 support, or evaluate if it's still necessary. If possible, it might be worth planning to drop support for this older version in a future release.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

phylum-io bot commented Oct 16, 2024

Phylum OSS Supply Chain Risk Analysis - SUCCESS

The Phylum risk analysis is complete and has passed the active policy.

View this project in the Phylum UI

@github-actions github-actions bot added the testing Improve testing & coverage label Oct 16, 2024
@Anselmoo Anselmoo disabled auto-merge October 16, 2024 19:28
@Anselmoo Anselmoo enabled auto-merge (squash) October 16, 2024 19:28
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b27b1a9) to head (a06eee6).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1651   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           45        45           
  Lines         4516      4518    +2     
=========================================
+ Hits          4516      4518    +2     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
spectrafit/__init__.py 100.00% <100.00%> (ø)
spectrafit/test/test_init.py 100.00% <100.00%> (ø)

Copy link

@Anselmoo Anselmoo merged commit 31dc115 into main Oct 16, 2024
33 checks passed
@Anselmoo Anselmoo deleted the next-release branch October 16, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file maintenance Maintenance & Security python Pull requests that update Python code release Release root size/S testing Improve testing & coverage vendor Add or modifying the vendor lib
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant