-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: ✨ fix syntax by adding missing commas in function signatures #1656
Conversation
Review changes with SemanticDiff. Analyzed 2 of 8 files. Overall, the semantic diff is 100% smaller than the GitHub diff. 2 files do not contain logic changes.
|
Reviewer's Guide by SourceryThis pull request focuses on improving code quality and updating development tools. The main changes include updating pre-commit hooks, fixing syntax issues, and adjusting code formatting configurations. Class diagram for updated function signaturesclassDiagram
class test_pptx_data {
+pptx_data: Tuple[PPTXDataAPI, OutputAPI, InputAPI, SolverAPI],
+test_pptx_data(pptx_data: Tuple[PPTXDataAPI, OutputAPI, InputAPI, SolverAPI])
}
class list2dict {
+peak_list: List[Dict[str, Dict[str, Dict[str, Any]]]],
+list2dict(peak_list: List[Dict[str, Dict[str, Dict[str, Any]]]])
}
note for test_pptx_data "Added missing comma in function signature"
note for list2dict "Added missing comma in function signature"
Pre-commit hooks updategraph TD;
A[Old Pre-commit Hooks] -->|Removed| B[black, blacken-docs, isort, flake8, pylint, pyupgrade]
A -->|Added| C[ruff, ruff-format]
A -->|Unchanged| D[mypy, pydocstyle, prettier]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Anselmoo - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a brief explanation in the project documentation about the switch to Ruff and its implications for the development workflow. This will help other contributors understand the change in linting and formatting tools.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1656 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 45 45
Lines 4518 4518
=========================================
Hits 4518 4518
Flags with carried forward coverage won't be shown. Click here to find out more.
|
All PR-Submissions:
Pull Requests for the same
update/change?
New ✨✨ Feature-Submissions:
Changes to ⚙️ Core-Features:
us to include them?
Summary by Sourcery
Fix syntax errors by adding missing commas in function signatures and enhance pre-commit configuration by replacing multiple hooks with ruff and ruff-format for code formatting and linting.
Bug Fixes:
Enhancements: