-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: ♻️ update setup script to install UV via curl instead of pip #1791
Conversation
Reviewer's Guide by SourceryThis pull request updates the setup script to install uv using curl instead of pip. This change ensures that uv is installed using the recommended installation method. Sequence diagram for updated UV installation processsequenceDiagram
participant S as Setup Script
participant P as pip
participant C as curl
participant UV as UV Installer
participant V as Virtual Environment
S->>P: Upgrade pip
S->>C: Download UV installer
C->>UV: Execute installer script
UV-->>S: UV installed
S->>V: Create Python 3.10 venv
S->>V: Sync dependencies
Flow diagram for the updated setup processgraph TD
A[Start Setup] --> B[Upgrade pip]
B --> C[Download UV installer via curl]
C --> D[Install UV]
D --> E[Create Python 3.10 venv]
E --> F[Sync dependencies]
F --> G[End Setup]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Anselmoo - I've reviewed your changes - here's some feedback:
Overall Comments:
- Piping curl directly to sh poses security risks. Consider downloading the script first and inspecting it before execution, or stick with the pip installation method.
- Please provide rationale for switching from pip to curl installation method. Are there specific advantages or requirements that necessitate this change?
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1791 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 45 45
Lines 4535 4535
=========================================
Hits 4535 4535
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
All PR-Submissions:
Pull Requests for the same
update/change?
New ✨✨ Feature-Submissions:
Changes to ⚙️ Core-Features:
us to include them?
Summary by Sourcery
Build: