Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ♻️ update setup script to install UV via curl instead of pip #1791

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

Anselmoo
Copy link
Owner

@Anselmoo Anselmoo commented Jan 22, 2025

All PR-Submissions:


  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open
    Pull Requests for the same
    update/change?

New ✨✨ Feature-Submissions:


  • Does your submission pass tests?
  • Have you lint your code locally prior to submission? Fixed:
  • This PR is for a new feature, not a bug fix.

Changes to ⚙️ Core-Features:


  • Have you added an explanation of what your changes do and why you'd like
    us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

Summary by Sourcery

Build:

  • Install UV using curl.

@Anselmoo Anselmoo enabled auto-merge January 22, 2025 21:12
Copy link

Review changes with  SemanticDiff

Copy link
Contributor

sourcery-ai bot commented Jan 22, 2025

Reviewer's Guide by Sourcery

This pull request updates the setup script to install uv using curl instead of pip. This change ensures that uv is installed using the recommended installation method.

Sequence diagram for updated UV installation process

sequenceDiagram
    participant S as Setup Script
    participant P as pip
    participant C as curl
    participant UV as UV Installer
    participant V as Virtual Environment

    S->>P: Upgrade pip
    S->>C: Download UV installer
    C->>UV: Execute installer script
    UV-->>S: UV installed
    S->>V: Create Python 3.10 venv
    S->>V: Sync dependencies
Loading

Flow diagram for the updated setup process

graph TD
    A[Start Setup] --> B[Upgrade pip]
    B --> C[Download UV installer via curl]
    C --> D[Install UV]
    D --> E[Create Python 3.10 venv]
    E --> F[Sync dependencies]
    F --> G[End Setup]
Loading

File-Level Changes

Change Details Files
Update the installation method for uv.
  • Replaced the pip installation command with a curl command to install uv.
.devcontainer/setup.sh

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added the codespaces Everything connected to GitHub's Codespaces label Jan 22, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Anselmoo - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Piping curl directly to sh poses security risks. Consider downloading the script first and inspecting it before execution, or stick with the pip installation method.
  • Please provide rationale for switching from pip to curl installation method. Are there specific advantages or requirements that necessitate this change?
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3596f33) to head (d4587b4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1791   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           45        45           
  Lines         4535      4535           
=========================================
  Hits          4535      4535           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Anselmoo Anselmoo disabled auto-merge January 23, 2025 05:50
@Anselmoo Anselmoo merged commit 5d2f6b9 into main Jan 23, 2025
18 checks passed
@Anselmoo Anselmoo deleted the feature/devcontainer branch January 23, 2025 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codespaces Everything connected to GitHub's Codespaces size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant