Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 migration plan #8

Open
DanielFaulkner opened this issue Oct 29, 2020 · 2 comments
Open

Python 3 migration plan #8

DanielFaulkner opened this issue Oct 29, 2020 · 2 comments

Comments

@DanielFaulkner
Copy link
Contributor

With Python 2 no longer supported and Qt5 now well established I have been making a few changes in one of my own branches, building on work by mp15, to add Python3 and Qt5 support to BioNanoAnalyst. This is now running on my machine using Linux, though further testing would be advisable, and I would like to contribute this work back upstream to gain better visibility.

Do you have a plan to create a Python3/Qt5 branch where these edits could be contributed to for testing or would you prefer these kinds of edits (many of which break Python2/Qt4 compatibility) to be contributed directly to the master branch?

Thanks,
Daniel

@yyx8671
Copy link
Contributor

yyx8671 commented Oct 30, 2020

Thanks Daniel,

I have been thinking to update the code and use the latest software versions. However, I haven't really got a time to do this. It would be nice if you can contribute your work and we will appreciate your help.

Cheers,
Andy

@DanielFaulkner
Copy link
Contributor Author

That's great. I'm happy to help a little, time permitting. I have issued a pull request (#11 ) for my work so far. But as it hasn't been extensively tested you may want to edit the commit to merge it into a development branch instead of the master branch until it has received further testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants