Qt5 Python3 conversion #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QPushButton now part of QtWidgets not QtGui
QVBoxLayout QGridLayout QPushButton QLineEdit QSpinBox all moved from QtGui to QtWidgets in Qt5
QDialogButtonBox moved from QtGui to QtWidgets in Qt5.
Auto gen fixes
The QtWidgets.QFileDialog.getOpenFileName function returns 2 values. Only the first is required, the second argument being present generates an error. Fix required for Linux, untested if required on win32 systems.
Fixes to dialog window returned file paths
QGraphicsView is now within QtWidgets instead of QtGui in Qt5.
Fixes to make App file compatible with Qt5
References to qApp needs to be updated to QtWidgets.QApplication for Qt5 compatibility.
Fixes to App file for Qt5 compatibility.
Updated Qt4 reference to Qt5.
Added brackets to print statements and fixed a whitespace issue when using Python 3.
Matplotlib figure.hold function has been depreciated. This line causes the program to lock up when using Python 3. However Matplotlib defaults to false so removing this line should have no effect on the programs output. It is possible this commit maybe applicable to branches using Python 2.
How the FileDialog module is imported has changed in Python 3. It is now imported from tkinter. The unicode function is no longer present in python 3, the easiest fix is to update calls to the unicode function with calls to the str function.
Fix a type mismatch error when using Python 3.
How the next function is called has changed in python 3. Updating it's use here to reflect that change.
Replaced references to python version 2 to reflect the updates made in this branch.
Fixes to statistics panel text
Replacing references to PySide to PySide2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit provides Python3 and Qt5 support. Tested under Linux using Qt 5.10 and Python 3.7.6. Only 'Option 2' has been tested using the provided sample data. Other datasets and operating systems should be tested before merging into Master. But this commit can be edited to merge into a development branch if preferred. This is based on the existing work done by user mp15.
No additional improvements/fixes have been made beyond the minimum required for Qt5/Py3 support and to fix an issue with file dialogue return paths which prevented testing.