add reading from pastastore #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dbrakenhoff
commented
Oct 24, 2023
dbrakenhoff
commented
- create Obs or ObsCollection from pastastore
- support renaming metadata fields
- create Obs or ObsCollection from pastastore - support renaming metadata fields
OnnoEbbens
requested changes
Oct 31, 2023
There was a problem hiding this comment.
Nice! Looks good to me. Two questions:
- Can you add a test for this? There is a test already where I create a Pastastore, so you can maybe add the reading to this test?
- I started adding
hydropandas.read_..(knmi, dino, bro, ..) functions. I saw there is not one for the pastastore yet. If you want to you can create one.
- add hpd.read_pastastore() function - improve docstrings - add test
OnnoEbbens
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.