Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lizard functionality to hydropandas #177

Merged
merged 9 commits into from
Jan 8, 2024
Merged

Add Lizard functionality to hydropandas #177

merged 9 commits into from
Jan 8, 2024

Conversation

anouksprong
Copy link
Collaborator

Functions added to extract metadata and timeseries from a Lizard-API

Functions to extract metadata and timeseries from a Lizard-API
@dbrakenhoff
Copy link
Collaborator

Nice! I've been looking forward to this development!

FYI, you'll want to point the Pull Request to the dev branch. You can modify that by pressing the edit button to the right of the PR title and selecting base: dev.

@dbrakenhoff dbrakenhoff added the enhancement New feature or request label Dec 19, 2023
@anouksprong anouksprong changed the base branch from master to dev December 19, 2023 15:30
@OnnoEbbens
Copy link
Collaborator

Hi Anouk, I made some changes to the lizard function mostly to make it more uniform with the rest of Hydropandas and some to speed up the code. Some things to note:

  • I changed the format of the extent from [xmin, ymin, xmax, ymax] to [xmin, xmax, ymin, ymax] in order to match the existing extent format
  • I merged read_lizard_from_extent and read_lizard_from_list into one function read_lizard
  • I've added some tests. I did not add tests yet to combine the 'diver' and 'handmetingen' because I don't know which tube has both. Do you have the code of a tube that has both? Than we can test this.
  • I really liked the part where you use the ThreadPoolExecutor to do some parallel processing, I might use this for other modules of hydropandas as well.

@OnnoEbbens OnnoEbbens merged commit 5d51d24 into dev Jan 8, 2024
@OnnoEbbens OnnoEbbens deleted the Lizard branch July 11, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants