DG-29 User admin update/Reports #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
temi
reviewed
Jun 12, 2024
grails-app/controllers/au/org/ala/volunteer/LabelController.groovy
Outdated
Show resolved
Hide resolved
grails-app/controllers/au/org/ala/volunteer/LandingPageAdminController.groovy
Outdated
Show resolved
Hide resolved
grails-app/controllers/au/org/ala/volunteer/ProjectController.groovy
Outdated
Show resolved
Hide resolved
grails-app/controllers/au/org/ala/volunteer/UserController.groovy
Outdated
Show resolved
Hide resolved
sbearcsiro
approved these changes
Jun 13, 2024
|
|
||
| class LabelController { | ||
|
|
||
| static allowedMethods = [save: "POST", update: "PUT", delete: "POST"] | ||
| // static allowedMethods = [saveNewLabel: "POST", updateCategory: "POST", saveCategory: "POST", createCategory: "POST", |
| def categoryId = params.long('id') | ||
| def category = LabelCategory.get(categoryId) | ||
| if (!category) { | ||
| log.info("No category found, redirecting back to index.") |
There was a problem hiding this comment.
Nit: Feels like debug logging not info?
| * @return a Map of user activity for a given date range. | ||
| */ | ||
| def getUserActivityBetweenDates(Date startDate, Date endDate) { | ||
| String query = """\ |
There was a problem hiding this comment.
Seems like you don't need to select to_timestamp(max(vt.lastView)/1000) as it's not used?
Also this could be done with jooq for typesafe queries, etc?
There was a problem hiding this comment.
This was in case Alex wanted date parameters on the existing User summary report, in the end he decided against. I'm tempted to leave it in if that requirement changes, if you're happy with it.
temi
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DG-29 User labels and Reporting
Labels
Reports