Added tvOS as Target #217
Merged
Added tvOS as Target #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AvdLee
approved these changes
Dec 13, 2022
Log/var/folders/11/nh0v1jld7zd7b9zqm1774gtm0000gn/T/_tmp_dangerfile.swift:1:8: error: no such module 'Danger'
import Danger
^
�[31mERROR: Dangerfile eval failed at Dangerfile.swift
�[0;0m�[31mERROR: Could not get the results JSON file at /var/folders/11/nh0v1jld7zd7b9zqm1774gtm0000gn/T/danger-response.json
�[0;0m |
|
@karm435 do the tests succeed locally? CI is currently broken, so I need some time to fix that |
|
😞 looks like it did not run tests locally. I will run them and see if I
could fix them.
…On Tue, 13 Dec 2022 at 8:23 pm, Antoine van der Lee < ***@***.***> wrote:
@karm435 <https://github.com/karm435> do the tests succeed locally? CI is
currently broken, so I need some time to fix that
—
Reply to this email directly, view it on GitHub
<#217 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABS47YTK34EMESQVIJ6NJ3TWNBFANANCNFSM6AAAAAASXM322Y>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I ran the tests locally and looks like that are fine. |
|
@karm435 they completed, but did the succeed as well? |
They are completed with Green color
|
|
Thanks for your contribution @karm435 |
|
You are welcome. I will see what else I can contribute to as I develop my app. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tvOS as Target in package.swift
Related to issue: #216