Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerated code for App Store Connect API 2.3 changes #223

Merged
merged 9 commits into from
Mar 16, 2023

Conversation

Workshed
Copy link
Contributor

The follow on from #220
Includes wrangling the openapi file for detail field not always being present in the ErrorResponse generated object.

@Workshed Workshed requested a review from AvdLee as a code owner March 10, 2023 19:31
@FelixLisczyk
Copy link

I would love to see this PR and #220 merged soon. The API changes are currently breaking most of my scripts. Thank you for your work! 👍

Copy link
Owner

@AvdLee AvdLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge once CI is done!

@SwiftLeeBot
Copy link
Collaborator

Warnings
⚠️ 'Prices' is deprecated: Deprecated
⚠️ 'AvailableTerritories' is deprecated: Deprecated
⚠️ 'InAppPurchases' is deprecated: Deprecated
⚠️ 'Prices' is deprecated: Deprecated
⚠️ 'AvailableTerritories' is deprecated: Deprecated
⚠️ 'InAppPurchases' is deprecated: Deprecated
⚠️ 'AppPrice' is deprecated: Deprecated
⚠️ 'AgeRatingDeclaration' is deprecated: Deprecated
⚠️ 'AgeRatingDeclaration' is deprecated: Deprecated
⚠️ 'AppStoreVersionSubmission' is deprecated: Deprecated
⚠️ 'AppStoreVersionSubmission' is deprecated: Deprecated
⚠️ 'Prices' is deprecated: Deprecated
⚠️ 'AvailableTerritories' is deprecated: Deprecated
⚠️ 'Prices' is deprecated: Deprecated
⚠️ 'AvailableTerritories' is deprecated: Deprecated
⚠️ 'AppPrice' is deprecated: Deprecated
⚠️ 'AppPrice' is deprecated: Deprecated
⚠️ 'AgeRatingDeclaration' is deprecated: Deprecated
⚠️ 'AppStoreVersionSubmission' is deprecated: Deprecated
⚠️ 'AppStoreVersionSubmission' is deprecated: Deprecated
⚠️ 'Prices' is deprecated: Deprecated
⚠️ 'AvailableTerritories' is deprecated: Deprecated
⚠️ 'AppPrice' is deprecated: Deprecated
⚠️ 'Prices' is deprecated: Deprecated
⚠️ 'AvailableTerritories' is deprecated: Deprecated
⚠️ 'InAppPurchases' is deprecated: Deprecated
⚠️

Consider to place some MARK: lines for Sources/OpenAPI/Generated/Entities/InAppPurchasePriceSchedule.swift, which is over 300 lines big.

⚠️

Consider to place some MARK: lines for Sources/OpenAPI/Generated/Paths/PathsV1AppsWithID.swift, which is over 300 lines big.

⚠️

Consider to place some MARK: lines for Sources/OpenAPI/Generated/Entities/App.swift, which is over 300 lines big.

⚠️

Consider to place some MARK: lines for Sources/OpenAPI/Generated/Paths/PathsV1AppsWithIDAppStoreVersions.swift, which is over 300 lines big.

⚠️

Consider to place some MARK: lines for Sources/OpenAPI/Generated/Paths/PathsV1Apps.swift, which is over 300 lines big.

⚠️

Consider to place some MARK: lines for Sources/OpenAPI/Generated/Entities/AppPriceSchedule.swift, which is over 300 lines big.

⚠️

Consider to place some MARK: lines for Sources/OpenAPI/Generated/Entities/AppEncryptionDeclaration.swift, which is over 300 lines big.

⚠️

Consider to place some MARK: lines for Sources/OpenAPI/Generated/Entities/AppPricePointV2.swift, which is over 300 lines big.

⚠️

Consider to place some MARK: lines for Sources/OpenAPI/Generated/Entities/AppInfo.swift, which is over 300 lines big.

⚠️

Consider to place some MARK: lines for Sources/OpenAPI/Generated/Paths/PathsV1CiProductsWithIDApp.swift, which is over 300 lines big.

⚠️

Consider to place some MARK: lines for Sources/OpenAPI/Generated/Paths/PathsV1CiBuildRunsWithIDBuilds.swift, which is over 300 lines big.

⚠️

Consider to place some MARK: lines for Sources/OpenAPI/Generated/Paths/PathsV1Builds.swift, which is over 300 lines big.

Messages
📖 AppStoreConnect-Swift-SDK-Tests: Executed 11 tests (0 failed, 0 retried, 0 skipped) in 0.058 seconds
📖

View more details on Bitrise

Code Coverage Report

Name Coverage

SwiftLint found issues

Severity File Reason
Warning Package.swift:32 Line should be 140 characters or less: currently 154 characters (line_length)

Generated by 🚫 Danger Swift against 68504ae

@AvdLee AvdLee merged commit 5c25146 into AvdLee:master Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants