Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation in Linux environment #233

Merged
merged 1 commit into from
May 24, 2023
Merged

Conversation

lvalenta
Copy link
Contributor

This MR makes sure the package compiles in Linux environment.

Tested in a Docker using Swift 5.8.

@lvalenta lvalenta requested a review from AvdLee as a code owner May 22, 2023 17:17
Copy link
Owner

@AvdLee AvdLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for your contribution!

@SwiftLeeBot
Copy link
Collaborator

SwiftLeeBot commented May 23, 2023

Warnings
⚠️ 'Prices' is deprecated: Deprecated
⚠️ 'AvailableTerritories' is deprecated: Deprecated
⚠️ 'InAppPurchases' is deprecated: Deprecated
⚠️ 'Prices' is deprecated: Deprecated
⚠️ 'AvailableTerritories' is deprecated: Deprecated
⚠️ 'InAppPurchases' is deprecated: Deprecated
⚠️ 'AppPrice' is deprecated: Deprecated
⚠️ 'AgeRatingDeclaration' is deprecated: Deprecated
⚠️ 'AgeRatingDeclaration' is deprecated: Deprecated
⚠️ 'AppStoreVersionSubmission' is deprecated: Deprecated
⚠️ 'AppStoreVersionSubmission' is deprecated: Deprecated
⚠️ 'Prices' is deprecated: Deprecated
⚠️ 'AvailableTerritories' is deprecated: Deprecated
⚠️ 'Prices' is deprecated: Deprecated
⚠️ 'AvailableTerritories' is deprecated: Deprecated
⚠️ 'AppPrice' is deprecated: Deprecated
⚠️ 'AppStoreVersionSubmission' is deprecated: Deprecated
⚠️ 'AppStoreVersionSubmission' is deprecated: Deprecated
⚠️ 'Prices' is deprecated: Deprecated
⚠️ 'AvailableTerritories' is deprecated: Deprecated
⚠️ 'AppPrice' is deprecated: Deprecated
⚠️ 'Prices' is deprecated: Deprecated
⚠️ 'AvailableTerritories' is deprecated: Deprecated
⚠️ 'InAppPurchases' is deprecated: Deprecated
⚠️ 'AppPrice' is deprecated: Deprecated
⚠️ 'AgeRatingDeclaration' is deprecated: Deprecated
Messages
📖 AppStoreConnect-Swift-SDK-Tests: Executed 16 tests (0 failed, 0 retried, 0 skipped) in 0.078 seconds
📖

View more details on Bitrise

Code Coverage Report

Name Coverage

SwiftLint found issues

Severity File Reason
Warning Package.swift:41 Line should be 140 characters or less; currently it has 154 characters (line_length)
Warning APIProvider.swift:76 Use shorthand syntax for optional binding (shorthand_optional_binding)
Warning APIProvider.swift:138 Lines should not have trailing whitespace (trailing_whitespace)
Warning APIProvider.swift:244 Lines should not have trailing whitespace (trailing_whitespace)
Warning APIProvider.swift:274 Lines should not have trailing whitespace (trailing_whitespace)
Warning APIProvider.swift:295 Lines should not have trailing whitespace (trailing_whitespace)
Warning APIProvider.swift:312 Lines should not have trailing whitespace (trailing_whitespace)
Warning APIProvider.swift:322 Lines should not have trailing whitespace (trailing_whitespace)
Warning APIProvider.swift:338 Lines should not have trailing whitespace (trailing_whitespace)
Warning APIProvider.swift:351 Lines should not have trailing whitespace (trailing_whitespace)
Warning APIProvider.swift:362 Lines should not have trailing whitespace (trailing_whitespace)
Warning APIProvider.swift:372 Lines should not have trailing whitespace (trailing_whitespace)
Warning APIProvider.swift:380 Lines should not have trailing whitespace (trailing_whitespace)
Warning APIProvider.swift:106 Parentheses are not needed when declaring closure arguments (unneeded_parentheses_in_closure_argument)

Generated by 🚫 Danger Swift against e1bf8fb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants