-
-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manually adds VISION_OS to Platform to work around OpenAPI spec issue #245
Conversation
OpenAPI spec 2.4 and 3.0 fails include VISION_OS. Filed as FB13208526.
@@ -9,4 +9,5 @@ public enum Platform: String, Codable, CaseIterable { | |||
case ios = "IOS" | |||
case macOs = "MAC_OS" | |||
case tvOs = "TV_OS" | |||
case visionOs = "VISION_OS" // VisionOS manually added since version 3.0 of Apple's OpenAPI spec fails to include it. Reported in FB13208526 27/9/2023. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure why GitHub shows the added line with a different indentation, but in Xcode it looks correct 🤷🏼
Code Coverage Report
SwiftLint found issues
Generated by 🚫 Danger Swift against 571426a |
I saw the same issue when I updated https://Bagbutik.dev to version 3.0 of the spec (MortenGregersen/Bagbutik#131). I have reported this as FB13071298. Apple has replied on my issue (September 19th):
Maybe you should make yours as duplicate of mine? I will update mine to reference yours. |
I've updated my feedback now to reference yours 🙏🏼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any thoughts for a better way to handle this?
Ideally, we would apply a custom parsing rule to CreateAPI, but this will do for now. Hopefully, it gets fixed by Apple soon!
The OpenAPI spec 2.4 and 3.0 fails include VISION_OS in Platform. This breaks several endpoints since the API is returning VISION_OS for all apps that support VisionOS.
Example from https://api.appstoreconnect.apple.com/v1/appInfos/xxx:
Feedback filed as FB13208526.
I'm unsure how to handle this without manually modifying Platform.swift and I realize that this "fix" will be undone next time a new version of the OpenAPI spec is generated (unless Apple fixes it in that version).
Any thoughts for a better way to handle this?