Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CreateApi to 0.2.0 #249

Merged
merged 3 commits into from
Dec 2, 2023
Merged

Update CreateApi to 0.2.0 #249

merged 3 commits into from
Dec 2, 2023

Conversation

nickasd
Copy link
Contributor

@nickasd nickasd commented Oct 9, 2023

Closes #248.


import Foundation

public enum Platform: String, Codable, CaseIterable {
case ios = "IOS"
case macOs = "MAC_OS"
case tvOs = "TV_OS"
case visionOs = "VISION_OS" // VisionOS manually added since version 3.0 of Apple's OpenAPI spec fails to include it. Reported in FB13208526 27/9/2023.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, we need to manually keep this line until Apple fixes VISION_OS missing in the spec or we come up with a better solution to handle this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just added it.

@AvdLee
Copy link
Owner

AvdLee commented Oct 26, 2023

@nickasd due to the last merge, there are some merge conflicts to solve. Could you have a look? 🙏

@nickasd
Copy link
Contributor Author

nickasd commented Oct 26, 2023

@nickasd due to the last merge, there are some merge conflicts to solve. Could you have a look? 🙏

Done, although there was no need to merge the OpenAPI 3.0 update, since mine is also updating to OpenAPI 3.1.

Copy link

This PR is stale because it has been open for 30 days with no activity. Remove the Stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Nov 26, 2023
@nickasd
Copy link
Contributor Author

nickasd commented Nov 26, 2023

The PR seems to be stale now. Do I still need to do anything?

@github-actions github-actions bot removed the Stale label Nov 27, 2023
@AvdLee
Copy link
Owner

AvdLee commented Dec 2, 2023

@nickasd definitely not! Merging in. Sorry, I've been a bit busy with other work lately! Let's goooo!

And thanks a lot for your contribution again! 🙏 Highly appreciated

@AvdLee AvdLee merged commit d345a2b into AvdLee:master Dec 2, 2023
@nickasd nickasd deleted the openapi-0.2.0 branch December 3, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CreateAPI to version 0.2.0
3 participants