-
-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CreateApi to 0.2.0 #249
Conversation
|
||
import Foundation | ||
|
||
public enum Platform: String, Codable, CaseIterable { | ||
case ios = "IOS" | ||
case macOs = "MAC_OS" | ||
case tvOs = "TV_OS" | ||
case visionOs = "VISION_OS" // VisionOS manually added since version 3.0 of Apple's OpenAPI spec fails to include it. Reported in FB13208526 27/9/2023. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, we need to manually keep this line until Apple fixes VISION_OS
missing in the spec or we come up with a better solution to handle this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, just added it.
@nickasd due to the last merge, there are some merge conflicts to solve. Could you have a look? 🙏 |
Done, although there was no need to merge the OpenAPI 3.0 update, since mine is also updating to OpenAPI 3.1. |
This PR is stale because it has been open for 30 days with no activity. Remove the Stale label or comment or this will be closed in 10 days. |
The PR seems to be stale now. Do I still need to do anything? |
@nickasd definitely not! Merging in. Sorry, I've been a bit busy with other work lately! Let's goooo! And thanks a lot for your contribution again! 🙏 Highly appreciated |
Closes #248.