Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update api spec and generate code for MetricInsight; #256

Merged
merged 2 commits into from
Jan 29, 2024
Merged

fix: Update api spec and generate code for MetricInsight; #256

merged 2 commits into from
Jan 29, 2024

Conversation

mat1th
Copy link
Contributor

@mat1th mat1th commented Jan 23, 2024

This is a manual update of the spec, because the spec is incorrect;

This PR fixes issues in Apple's API Spec:

  • The referenceVersions in the spec from apple lists only a String but the real response is a array of Strings.
  • The percentageBreakdown in the spec from apple lists only 1 object but the realresponse is an array of PercentageBreakdownItem.

@mat1th mat1th requested a review from AvdLee as a code owner January 23, 2024 13:06
@SwiftLeeBot
Copy link
Collaborator

Warnings
⚠️ 'Prices' is deprecated: Deprecated
⚠️ 'AvailableTerritories' is deprecated: Deprecated
⚠️ 'InAppPurchases' is deprecated: Deprecated
⚠️ 'Prices' is deprecated: Deprecated
⚠️ 'AvailableTerritories' is deprecated: Deprecated
⚠️ 'InAppPurchases' is deprecated: Deprecated
⚠️ 'Builds' is deprecated: Deprecated
⚠️ 'Builds' is deprecated: Deprecated
⚠️ 'AppPreOrder' is deprecated: Deprecated
⚠️ 'AppPrice' is deprecated: Deprecated
⚠️ 'InAppPurchase' is deprecated: Deprecated
⚠️ 'GameCenterEnabledVersion' is deprecated: Deprecated
⚠️ 'AgeRatingDeclaration' is deprecated: Deprecated
⚠️ 'AgeRatingDeclaration' is deprecated: Deprecated
⚠️ 'AppStoreVersionExperiment' is deprecated: Deprecated
⚠️ 'AppStoreVersionExperiment' is deprecated: Deprecated
⚠️ 'AppStoreVersionSubmission' is deprecated: Deprecated
⚠️ 'AppStoreVersionExperiment' is deprecated: Deprecated
⚠️ 'AppStoreVersionSubmission' is deprecated: Deprecated
⚠️ 'AppStoreVersionExperiment' is deprecated: Deprecated
⚠️ 'Prices' is deprecated: Deprecated
⚠️ 'AvailableTerritories' is deprecated: Deprecated
⚠️ 'Prices' is deprecated: Deprecated
⚠️ 'AvailableTerritories' is deprecated: Deprecated
⚠️ 'AppPreOrder' is deprecated: Deprecated
⚠️ 'AppPrice' is deprecated: Deprecated
⚠️ 'InAppPurchase' is deprecated: Deprecated
⚠️ 'GameCenterEnabledVersion' is deprecated: Deprecated
⚠️ 'AppStoreVersionExperiment' is deprecated: Deprecated
⚠️ 'AppStoreVersionExperiment' is deprecated: Deprecated
⚠️ 'AppStoreVersionExperiment' is deprecated: Deprecated
⚠️ 'AppStoreVersionExperiment' is deprecated: Deprecated
⚠️ 'Builds' is deprecated: Deprecated
⚠️ 'AgeRatingDeclaration' is deprecated: Deprecated
⚠️ 'Prices' is deprecated: Deprecated
⚠️ 'AvailableTerritories' is deprecated: Deprecated
⚠️ 'InAppPurchases' is deprecated: Deprecated
⚠️ 'AppStoreVersionSubmission' is deprecated: Deprecated
⚠️ 'AppStoreVersionExperiment' is deprecated: Deprecated
⚠️ 'AppStoreVersionSubmission' is deprecated: Deprecated
⚠️ 'AppStoreVersionExperiment' is deprecated: Deprecated
⚠️ 'Prices' is deprecated: Deprecated
⚠️ 'AvailableTerritories' is deprecated: Deprecated
⚠️ 'AppPreOrder' is deprecated: Deprecated
⚠️ 'AppPrice' is deprecated: Deprecated
⚠️ 'InAppPurchase' is deprecated: Deprecated
⚠️ 'GameCenterEnabledVersion' is deprecated: Deprecated
⚠️ 'AppPreOrder' is deprecated: Deprecated
⚠️ 'AppPrice' is deprecated: Deprecated
⚠️ 'InAppPurchase' is deprecated: Deprecated
⚠️ 'GameCenterEnabledVersion' is deprecated: Deprecated
⚠️ 'AppStoreVersionExperiment' is deprecated: Deprecated
⚠️ 'AppStoreVersionExperiment' is deprecated: Deprecated
Messages
📖 AppStoreConnect-Swift-SDK-Tests: Executed 17 tests (0 failed, 0 retried, 0 skipped) in 0.148 seconds
📖

View more details on Bitrise

Code Coverage Report

Name Coverage

SwiftLint found issues

Severity File Reason
Error MetricsInsight.swift:25 Line should be 160 characters or less; currently it has 200 characters (line_length)
Error MetricsInsight.swift:55 Line should be 160 characters or less; currently it has 302 characters (line_length)
Warning MetricsInsight.swift:7 An 'instance_property' should not be placed amongst the type content(s) 'subtype' (type_contents_order)
Warning MetricsInsight.swift:8 An 'instance_property' should not be placed amongst the type content(s) 'subtype' (type_contents_order)
Warning MetricsInsight.swift:9 An 'instance_property' should not be placed amongst the type content(s) 'subtype' (type_contents_order)
Warning MetricsInsight.swift:10 An 'instance_property' should not be placed amongst the type content(s) 'subtype' (type_contents_order)
Warning MetricsInsight.swift:11 An 'instance_property' should not be placed amongst the type content(s) 'subtype' (type_contents_order)
Warning MetricsInsight.swift:12 An 'instance_property' should not be placed amongst the type content(s) 'subtype' (type_contents_order)
Warning MetricsInsight.swift:13 An 'instance_property' should not be placed amongst the type content(s) 'subtype' (type_contents_order)
Warning MetricsInsight.swift:14 An 'instance_property' should not be placed amongst the type content(s) 'subtype' (type_contents_order)
Warning MetricsInsight.swift:15 An 'instance_property' should not be placed amongst the type content(s) 'subtype' (type_contents_order)
Error XcodeMetrics.swift:154 Line should be 160 characters or less; currently it has 169 characters (line_length)
Warning XcodeMetrics.swift:7 An 'instance_property' should not be placed amongst the type content(s) 'subtype' (type_contents_order)
Warning XcodeMetrics.swift:8 An 'instance_property' should not be placed amongst the type content(s) 'subtype' (type_contents_order)
Warning XcodeMetrics.swift:9 An 'instance_property' should not be placed amongst the type content(s) 'subtype' (type_contents_order)

Generated by 🚫 Danger Swift against 7e35e3f

Copy link
Owner

@AvdLee AvdLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes total sense, thanks a lot for taking care of this!

@AvdLee AvdLee merged commit 3489a06 into AvdLee:master Jan 29, 2024
@mat1th mat1th deleted the feature/manually-update-api-spec-to-fix-api-response-in-perfPowerMetrics branch January 30, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants