Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initializer which reads the private key from a file. #272

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

jzilske
Copy link
Contributor

@jzilske jzilske commented May 3, 2024

As per the documentation:

Keep your API keys secure and private. Don’t share your keys, store keys in a code repository, or include keys in client-side code.

@jzilske jzilske requested a review from AvdLee as a code owner May 3, 2024 10:53
@SwiftLeeBot
Copy link
Collaborator

SwiftLeeBot commented May 3, 2024

Warnings
⚠️ 'Prices' is deprecated: Deprecated
⚠️ 'AvailableTerritories' is deprecated: Deprecated
⚠️ 'InAppPurchases' is deprecated: Deprecated
⚠️ 'Prices' is deprecated: Deprecated
⚠️ 'AvailableTerritories' is deprecated: Deprecated
⚠️ 'InAppPurchases' is deprecated: Deprecated
⚠️ 'Builds' is deprecated: Deprecated
⚠️ 'Builds' is deprecated: Deprecated
⚠️ 'AppPreOrder' is deprecated: Deprecated
⚠️ 'AppPrice' is deprecated: Deprecated
⚠️ 'InAppPurchase' is deprecated: Deprecated
⚠️ 'GameCenterEnabledVersion' is deprecated: Deprecated
⚠️ 'AgeRatingDeclaration' is deprecated: Deprecated
⚠️ 'AgeRatingDeclaration' is deprecated: Deprecated
⚠️ 'AppStoreVersionExperiment' is deprecated: Deprecated
⚠️ 'AppStoreVersionExperiment' is deprecated: Deprecated
⚠️ 'AppStoreVersionSubmission' is deprecated: Deprecated
⚠️ 'AppStoreVersionExperiment' is deprecated: Deprecated
⚠️ 'AppStoreVersionSubmission' is deprecated: Deprecated
⚠️ 'AppStoreVersionExperiment' is deprecated: Deprecated
⚠️ 'Prices' is deprecated: Deprecated
⚠️ 'AvailableTerritories' is deprecated: Deprecated
⚠️ 'Prices' is deprecated: Deprecated
⚠️ 'AvailableTerritories' is deprecated: Deprecated
⚠️ 'AppPreOrder' is deprecated: Deprecated
⚠️ 'AppPrice' is deprecated: Deprecated
⚠️ 'InAppPurchase' is deprecated: Deprecated
⚠️ 'GameCenterEnabledVersion' is deprecated: Deprecated
⚠️ 'AppStoreVersionExperiment' is deprecated: Deprecated
⚠️ 'AppStoreVersionExperiment' is deprecated: Deprecated
⚠️ 'AppStoreVersionSubmission' is deprecated: Deprecated
⚠️ 'AppStoreVersionExperiment' is deprecated: Deprecated
⚠️ 'AppStoreVersionSubmission' is deprecated: Deprecated
⚠️ 'AppStoreVersionExperiment' is deprecated: Deprecated
⚠️ 'Prices' is deprecated: Deprecated
⚠️ 'AvailableTerritories' is deprecated: Deprecated
⚠️ 'AppPreOrder' is deprecated: Deprecated
⚠️ 'AppPrice' is deprecated: Deprecated
⚠️ 'InAppPurchase' is deprecated: Deprecated
⚠️ 'GameCenterEnabledVersion' is deprecated: Deprecated
⚠️ 'Builds' is deprecated: Deprecated
⚠️ 'AppPreOrder' is deprecated: Deprecated
⚠️ 'AppPrice' is deprecated: Deprecated
⚠️ 'InAppPurchase' is deprecated: Deprecated
⚠️ 'GameCenterEnabledVersion' is deprecated: Deprecated
⚠️ 'AgeRatingDeclaration' is deprecated: Deprecated
⚠️ 'Prices' is deprecated: Deprecated
⚠️ 'AvailableTerritories' is deprecated: Deprecated
⚠️ 'InAppPurchases' is deprecated: Deprecated
⚠️ 'AppStoreVersionExperiment' is deprecated: Deprecated
⚠️ 'AppStoreVersionExperiment' is deprecated: Deprecated
⚠️ 'AppStoreVersionExperiment' is deprecated: Deprecated
⚠️ 'AppStoreVersionExperiment' is deprecated: Deprecated
Messages
📖 AppStoreConnect-Swift-SDK-Tests: Executed 17 tests (0 failed, 0 retried, 0 skipped) in 0.300 seconds
📖

View more details on Bitrise

Code Coverage Report

Name Coverage

SwiftLint found issues

Severity File Reason
Warning APIProvider.swift:59 Use shorthand syntax for optional binding (shorthand_optional_binding)
Warning APIProvider.swift:98 Use shorthand syntax for optional binding (shorthand_optional_binding)
Warning APIProvider.swift:50 Lines should not have trailing whitespace (trailing_whitespace)
Warning APIProvider.swift:166 Lines should not have trailing whitespace (trailing_whitespace)
Warning APIProvider.swift:272 Lines should not have trailing whitespace (trailing_whitespace)
Warning APIProvider.swift:302 Lines should not have trailing whitespace (trailing_whitespace)
Warning APIProvider.swift:323 Lines should not have trailing whitespace (trailing_whitespace)
Warning APIProvider.swift:340 Lines should not have trailing whitespace (trailing_whitespace)
Warning APIProvider.swift:350 Lines should not have trailing whitespace (trailing_whitespace)
Warning APIProvider.swift:366 Lines should not have trailing whitespace (trailing_whitespace)
Warning APIProvider.swift:379 Lines should not have trailing whitespace (trailing_whitespace)
Warning APIProvider.swift:390 Lines should not have trailing whitespace (trailing_whitespace)
Warning APIProvider.swift:400 Lines should not have trailing whitespace (trailing_whitespace)
Warning APIProvider.swift:408 Lines should not have trailing whitespace (trailing_whitespace)
Warning APIProvider.swift:128 Parentheses are not needed when declaring closure arguments (unneeded_parentheses_in_closure_argument)

Generated by 🚫 Danger Swift against 805ed9e

Copy link

github-actions bot commented Jun 6, 2024

This PR is stale because it has been open for 30 days with no activity. Remove the Stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Jun 6, 2024
@AvdLee AvdLee merged commit 0fef5f6 into AvdLee:master Jun 10, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants