feat: mount pvc on jobs #1982
Merged
feat: mount pvc on jobs #1982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @BenjaminDecreusefond I think you will need to do some additional changes to this PR, maybe adding some code to validate if PVC_CLAIM_NAME is present if not the container will break because the is no pvc to add. |
|
Hi @alfespa17 ! Made rectification on the code ! Lemme know :) |
|
It looks better now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @alfespa17 !
I'd like to propose this small change for ephemeral agents. The idea is that we use a Persistent volume claim (PVC) that we mount on our jobs at each run. Then since
TF_PLUGIN_CACHE_DIRis set, tofu "automatically" comes to grab the content of this folder in case the provider was previously downloaded.NB: PVC must be defined in the Terrakube Helm charts. Terrakube app should not be responsible for PVC provisionning.
Lemme know your thoughts
PS: not tested