Skip to content

feat: allow remote apply for vcs workspace #1985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

BenjaminDecreusefond
Copy link
Contributor

@BenjaminDecreusefond BenjaminDecreusefond commented Apr 2, 2025

Hi @alfespa17 !

I made this change as workaround for remote apply. This allows us to set a boolean to allow remote apply with VCS workspace. This can be useful to be able to use all features of VCS (like github connection) and avoid being blocked by VCS remote apply. I'd like your input as it changes the philosophy of VCS !

PS: UI part was not added due to lack of knowledge on UI components + I believe this parameter should only be used if really necessary.

Regards !

@alfespa17
Copy link
Member

You are adding a new column to the table you need to create the script to add the new column to the database, you could check several examples here

https://github.com/AzBuilder/terrakube/tree/main/api/src/main/resources/db/changelog/local

Can you rename this private boolean allow_remote_apply = false; to private boolean allowRemoteApply = false; to follow the same naming convention

@alfespa17 alfespa17 marked this pull request as draft April 2, 2025 21:40
@BenjaminDecreusefond
Copy link
Contributor Author

BenjaminDecreusefond commented Apr 3, 2025

Hi @alfespa17 !

I made some changes, lemme know what you think ! :)

Can't catch why the CI is failing tho ? :/

@alfespa17
Copy link
Member

Look like test cases are failing you can run mvn test in your local machine to do some debugging

@BenjaminDecreusefond
Copy link
Contributor Author

Hi @alfespa17 !

Was able to find a fix for the CI ! Should be good now ! :)

@alfespa17 alfespa17 marked this pull request as ready for review April 4, 2025 17:43
@alfespa17 alfespa17 merged commit 48fa397 into AzBuilder:main Apr 4, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants