Update Deploy.ps1 #500
Merged
Update Deploy.ps1 #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added numeric check for keyvault names
|
@neelavarshad - could you please add an issue to this PR? |
|
Added Issue #512 |
|
@louisephilardeau is working on testing this |
|
Hi @neelavarshad, the PR looks good to me, can confirm after testing that the regex no longer allows for KeyVault name to start with a number, and all other existing behavior still works as expected. One quick note: The change in regex also excludes the name from starting with a hyphen - assuming this is desired, would it make sense to call this out in the error message by specifying that the name can only start with a letter? |
Updated keyvault error message
louiseph
approved these changes
Jun 5, 2023
|
Thank you @louiseph |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added numeric check for keyvault names