Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed scheduler time zone validation error #518

Merged
merged 5 commits into from
Jul 21, 2023

Conversation

louiseph
Copy link
Contributor

@louiseph louiseph commented Jun 6, 2023

The date time conversion was happening inside the form element causing confusing UI and potential validation errors when treating local time as UTC. Proposed solution would be to keep everything locale-based on the client side, while doing any UTC conversions on the backend by passing in the TimezoneOffset parameter.

@louiseph
Copy link
Contributor Author

louiseph commented Jun 6, 2023

@microsoft-github-policy-service agree company="Microsoft"

@santhoshb-msft
Copy link
Contributor

Hi @louiseph added some comments on this PR.

@louiseph
Copy link
Contributor Author

 

Local Time: 12 pm PDT

  Expected behavior Past Behavior Actual Behavior
test < 5 am PDT Doesn’t create metered trigger Doesn’t create metered trigger Doesn’t create metered trigger
5 am PDT < test < 12 pm PDT Doesn't create metered trigger Creates metered trigger Doesn’t create metered trigger
12 pm PDT < test Creates metered trigger Creates metered trigger Creates metered trigger

@santhoshb-msft
Copy link
Contributor

santhoshb-msft commented Jul 13, 2023

@louiseph looks like its still showing the same issue. When I input the start time, it is not taking into account of the timezone and timezone is coming through as 0

@msalemcode
Copy link
Contributor

Reviewed and tested the change and it worked as expected.

@santhoshb-msft
Copy link
Contributor

@msalemcode I think lets hold off on this as when I tried with a different time zone browser it didnt work. Can you confirm if that works for you?

@santhoshb-msft
Copy link
Contributor

Thanks @msalemcode and @code4clouds

@santhoshb-msft santhoshb-msft merged commit 3515d26 into Azure:main Jul 21, 2023
@santhoshb-msft santhoshb-msft linked an issue Jul 24, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scheduler UI doesn't work with time zones
3 participants