Mitigated CodeQL logging security Alerts #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
dstarr
reviewed
Jul 27, 2023
Closed
santhoshb-msft
added
the
enhancement
|
@msalemcode there seems to be some conflicts, could you please resolve them? |
msalemcode
force-pushed
the
main
branch
2 times, most recently
from
65a7b01 to
de7bc3d
Compare
code4clouds
approved these changes
Aug 4, 2023
| @@ -1,4 +1,5 @@ | |||
| using System.Linq; | |||
| using System.Web; | |||
There was a problem hiding this comment.
Did you add a code that requires the System.Web?
| @@ -1,5 +1,6 @@ | |||
| using System; | |||
| using System.Collections.Generic; | |||
| using System.Web; | |||
There was a problem hiding this comment.
Did you add a code that requires the System.Web?
| { | ||
| /// <summary> | ||
| /// The logger. | ||
| /// </summary> | ||
| private readonly ILogger<MeteredBillingApiService> logger; | ||
| private ILogger<T> logger; |
There was a problem hiding this comment.
readonly made sense on the old code... If this is not going to be re-assigned later, it makes sense to have it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR to fix CodeQL logging security alerts.
1- Centralize logging to use a common library under services
2- Adding Encoding methods to encode user input to prevent sql injection
3- Prevent Exposure of private information