Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding scheduler notification #537

Merged
merged 3 commits into from
Aug 9, 2023
Merged

Adding scheduler notification #537

merged 3 commits into from
Aug 9, 2023

Conversation

msalemcode
Copy link
Contributor

Enable Scheduler engine to send email notification to ISV for missing, successful and failure metered event.
Also, logging the engine events into App logging table

@msalemcode msalemcode added the enhancement A request for new functionality or improvement label Aug 8, 2023
code4clouds
code4clouds requested changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@code4clouds code4clouds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like we need a base class for setting the default emailcontent properties and then extend for the specific usage on both PrepareMeteredEmailContent and PrepareEmailContent

@msalemcode msalemcode requested a review from code4clouds August 8, 2023 22:45
@santhoshb-msft santhoshb-msft mentioned this pull request Aug 8, 2023
Closed
@msalemcode msalemcode merged commit c10befc into Azure:main Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@code4clouds code4clouds code4clouds approved these changes

Assignees
No one assigned
Labels
enhancement A request for new functionality or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msalemcode @code4clouds