Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new properties to the Subscriptions table #549

Merged
merged 10 commits into from
Sep 29, 2023

Conversation

alexdrenea
Copy link
Collaborator

@alexdrenea alexdrenea commented Sep 12, 2023

  • OfferId (Name) and Term details (Name, StartDate, EndDate)
  • Updated subscriptions page both admin and customer to show Offer Name
  • Updated subscriptions details page to show term details

Note!
For customers upgrading from an older version of accelerator, they should use the upgrade.ps1 script to upgrade the code and database, then run a "Fetch all Subscriptions" to populate the new fields.

Addresses #548

Subscriptions page:
image

Subscription Details Page:
image

  - OfferId (Name) and Term details (Name, StartDate, EndDate)
- Updated subscriptions page both admin and customer to show OfferName
- Updated subscriptions details page to show term details
alexdrenea and others added 2 commits September 12, 2023 11:00
* updating format and presentation of JSON
* made changes from feedback: table over comments
- Need to ensure we update these values based on incoming webhook and that is undergoing changes.
@santhoshb-msft santhoshb-msft linked an issue Sep 25, 2023 that may be closed by this pull request
Copy link
Contributor

@santhoshb-msft santhoshb-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the migration and Ui changes.
@alexdrenea could you please merge your branch from main latest.

  - OfferId (Name) and Term details (Name, StartDate, EndDate)
- Updated subscriptions page both admin and customer to show OfferName
- Updated subscriptions details page to show term details
- Need to ensure we update these values based on incoming webhook and that is undergoing changes.
Copy link
Contributor

@santhoshb-msft santhoshb-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified in both new and upgrade scenarios.

@santhoshb-msft santhoshb-msft merged commit f840f3c into Azure:main Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Offer Name column in Admin and Customer portal
3 participants