adding logic to check if Key Vault or SQL server exists. #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msalemcode
changed the title
code4clouds
requested changes
Oct 27, 2023
code4clouds
requested changes
Oct 27, 2023
code4clouds
requested changes
Oct 27, 2023
deployment/Deploy.ps1
Outdated
| Write-Host "To Purge KeyVault please use the following doc:" | ||
| Write-Host "https://learn.microsoft.com/en-us/cli/azure/keyvault?view=azure-cli-latest#az-keyvault-purge." | ||
| Write-Host "You could use new KeyVault name by using parameter -KeyVault" | ||
| Throw "🛑 KeyVault name already exists." |
There was a problem hiding this comment.
Do not throw the error, instead provide the message as is and exit with 1
code4clouds
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
@msalemcode Its all good... just add an extra space on the emoji and merge.
dstarr
approved these changes
Nov 3, 2023
code4clouds
approved these changes
Nov 11, 2023
|
@msalemcode - Code approved, pleases merge when ready. |
code4clouds
approved these changes
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding logic to deployment script to exit if Key Vault exists and deleted and give information how to proceed.