Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Existing KeyVault to process withput breaking #670

Merged
merged 5 commits into from
Mar 27, 2024

Conversation

msalemcode
Copy link
Contributor

If user passed KeyVault name or Accelerator deployed over existing resouces, Script will exist due to existing KeyVault and direct user to purge KeyVault.

Solution:
1- If user provided KeyVault name, Deployment script will by pass the validation. It is user responsibility to provide existing valid KeyVault name
2- If Deployment used auto generated keyvault name then there is two different actions:

  • If KeyVault exists then it will pass and proceed with deployment.
  • If KeyVault does not exist then it will check if the KeyVault was deleted before or not.

@neelavarshad
Copy link
Contributor

@msalemcode The validation is right, although the script could still fail, if the user provides the name of a keyvault that already exists.
At the time of deploying azure resource (after preparing publish files), we are calling az create again on the same keyvault name, there should be a check to ensure we are not recreating keyvault if it already exists.

@santhoshb-msft santhoshb-msft removed their assignment Mar 15, 2024
@neelavarshad neelavarshad merged commit f2e531b into Azure:main Mar 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants