Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show release version on both apps and new release #721

Merged
merged 7 commits into from
Aug 15, 2024
Merged

Show release version on both apps and new release #721

merged 7 commits into from
Aug 15, 2024

Conversation

santhoshb-msft
Copy link
Contributor

  1. Create Classes to store AppVersion and latest version from Git
  2. Logic to fetch the new release from this repo
  3. Show the release number on both customer app, admin app and metering project
  4. Compare the current release with new release and add msg to Admin-home on new release available message.

@santhoshb-msft santhoshb-msft changed the title Added changes to show release version on both apps and new release Show release version on both apps and new release Jun 24, 2024
namespace Marketplace.SaaS.Accelerator.Services.Services;

/// <summary>
/// AppVersionService Service.
Copy link

@007zszmz 007zszmz Jul 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-blocking: provide an example of the version in the comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
image
image

@santhoshb-msft
Copy link
Contributor Author

@007zszmz can you please review on your comments and help with an approval.

@santhoshb-msft
Copy link
Contributor Author

@neelavarshad @007zszmz can you help approve this please?

@neelavarshad
Copy link
Contributor

@santhoshb-msft Is this expected for first publish?
image

@santhoshb-msft
Copy link
Contributor Author

@santhoshb-msft Is this expected for first publish? image

Yes @neelavarshad this is expected, if someone deploys any branch other than the release, we show this. We could probably make it 0.0.0 if need be.

Copy link
Contributor

@neelavarshad neelavarshad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved all changes

@neelavarshad neelavarshad merged commit 31c7abd into Azure:main Aug 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants