Deploy fix #738
Merged
Deploy fix #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santhoshb-msft
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily focuses on refactoring the PowerShell scripts
Deploy.ps1andUpgrade.ps1in thedeploymentdirectory. The changes involve repositioning theParamblocks in both scripts to be at the top of the file, right after the initial comments.Changes in
Deploy.ps1:Paramblock, which declares various parameters required for deployment, has been moved to the top of the script. This block was previously located inside anifstatement. The parameters include the web application name prefix, resource group for deployment, location, publisher admin users, tenant ID, Azure subscription ID, Active Directory application ID and secret, multi-tenant Active Directory application ID for admin and landing portal, SQL database name, SQL server name, logo URLs, KeyVault name, and a quiet switch. [1] [2]Changes in
Upgrade.ps1:Deploy.ps1, theParamblock inUpgrade.ps1has been moved to the top of the script. This block declares the web application name prefix and the resource group for deployment as mandatory parameters. [1] [2]These changes enhance the readability and maintainability of the scripts by following the common practice of defining parameters at the beginning of the script.