Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Dotnet 8TLS #749

Merged
merged 7 commits into from
Aug 29, 2024
Merged

Conversation

msalemcode
Copy link
Contributor

Description

This PR updates the SaaS Accelerator project to use .NET 8 LTS. This upgrade ensures that the project benefits from the latest features, performance improvements, and security updates provided by .NET 8 LTS.

Changes Made

  1. Project File Updates:

    • Updated the target framework in the project files to net8.0.
  2. Package Updates:

    • Updated NuGet packages to versions compatible with .NET 8 LTS.
  3. Code Adjustments:

    • Made necessary code changes to ensure compatibility with .NET 8 LTS.
    • Refactored deprecated APIs and replaced them with their .NET 8 LTS equivalents.
  4. Configuration Updates:

    • Updated configuration files, such as appsettings.json and appsettings.test.json, to align with .NET 8 LTS best practices.

Impact

  • Performance Improvements: Leveraging the performance enhancements in .NET 8 LTS.
  • Security Enhancements: Utilizing the latest security features and updates in .NET 8 LTS.
  • Long-Term Support: Ensuring the project is on a supported version of .NET for the foreseeable future.

Testing

  • Unit Tests: All existing unit tests have been run and updated where necessary to ensure compatibility with .NET 8 LTS.
  • Integration Tests: Conducted integration tests to verify that all components of the SaaS Accelerator work seamlessly with .NET 8 LTS.
  • Manual Testing: Performed manual testing of critical paths to ensure no regressions or issues were introduced.

Conclusion

This PR upgrades the SaaS Accelerator to .NET 8 LTS, bringing in the latest improvements and ensuring long-term support. The update includes necessary code adjustments, package updates, and configuration changes to maintain compatibility and leverage the benefits of .NET 8 LTS.

Copy link
Contributor

@santhoshb-msft santhoshb-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added comments

Copy link

@fthorntonai fthorntonai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • [Approved] Unit Tests: All existing unit tests have been run and updated where necessary to ensure compatibility with .NET 8 LTS.
  • [Approved ] Integration Tests: Conducted integration tests to verify that all components of the SaaS Accelerator work seamlessly with .NET 8 LTS.
  • [Approved] Manual Testing: Performed manual testing of critical paths to ensure no regressions or issues were introduced.

Copy link

@v-ade v-ade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. Reviewed and okay.

@v-ade v-ade self-requested a review August 22, 2024 01:30
@fthorntonai
Copy link

fthorntonai commented Aug 23, 2024

  • [Approved] Unit Tests: All existing unit tests have been run and updated where necessary to ensure compatibility with .NET 8 LTS.
  • [Approved ] Integration Tests: Conducted integration tests to verify that all components of the SaaS Accelerator work seamlessly with .NET 8 LTS.
  • [Approved] Manual Testing: Performed manual testing of critical paths to ensure no regressions or issues were introduced.
  • [WIP] E2E Manual Testing: Performed E2E testing of
    git fetch origin pull/749/head:8ltsupgrade
    1. deploy PR to a new instance
    2. update an offer tech config to the details of the above instance
    3. Run an e2e customer purchase exp ,
    - [ Verified ] pending
    - [ Verified* ] activate
    - [ Verified ] customer change plan from portal - webhook testing
    - update admin portal setting "AcceptSubscriptioUpdates" to true
    - and try the change plan.
    - [ WIP ] meter
    -
    -
    - [ WIP ] scheduled meter
    -
    -
    - [ Verified ] unsubscribe
  • action works but i either received an initial error or request screenshot
    ------- install warning --------
    The Entity Framework tools version '8.0.0' is older than that of the runtime '8.0.6'. Update the tools for the latest features and bug fixes. See https://aka.ms/AAc1fbw for more information.

Copy link

@fthorntonai fthorntonai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run an e2e customer purchase exp

  • [ Verified ] pending
  • [ Verified ] activate
  • [ Verified ] customer change plan from portal - webhook testing
    • update admin portal setting "AcceptSubscriptioUpdates" to true
    • and try the change plan.
  • [ Accepted ] create metered billing plan
  • [ Accepted ] scheduled meter billing
  • [ Verified ] unsubscribe from offer

Copy link
Contributor

@santhoshb-msft santhoshb-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested By Adedayo and Fredrick and Myself. Approving this.

@santhoshb-msft santhoshb-msft merged commit 9ce5725 into Azure:main Aug 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants