Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified logic to show three part version, removing the revision #766

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

santhoshb-msft
Copy link
Contributor

This pull request includes changes to the AppVersionService implementation across multiple files, simplifying how the application version is handled and removing unnecessary properties. The most important changes include updating the service registration in Startup.cs files, removing redundant properties from the IAppVersionService interface, and modifying the AppVersionService class to use the Version class instead of FileVersionInfo.

Changes to service registration:

  • src/AdminSite/Startup.cs: Updated the ConfigureServices method to register IAppVersionService using the Version class instead of FileVersionInfo.
  • src/CustomerSite/Startup.cs: Updated the ConfigureServices method similarly to the AdminSite to use the Version class.

Simplification of IAppVersionService:

Modification of AppVersionService:

Code cleanup:

@santhoshb-msft santhoshb-msft changed the title simplified logic to show three part version, removing the revision Simplified logic to show three part version, removing the revision Oct 1, 2024
@fthorntonai fthorntonai self-assigned this Oct 2, 2024
Copy link

@fthorntonai fthorntonai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 3 part version displays in Apps AdminPortal and Client Portal

@santhoshb-msft santhoshb-msft merged commit 3658c32 into Azure:main Oct 3, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants