Connection String Parsing Enhancement for Upgrade Script

[DmarshalTU]

Connection String Parsing Enhancement for Upgrade Script

Problem

The current upgrade script fails when parsing connection strings due to rigid string parsing that doesn't handle different connection string formats. This causes the upgrade process to fail with the error:

Exception calling "Substring" with "2" argument(s): "length ('-168') must be a non-negative value. (Parameter 'length') Actual value was -168."

Installation process:

Set-AzContext -Subscription SUB
wget https://dotnet.microsoft.com/download/dotnet/scripts/v1/dotnet-install.sh
chmod +x dotnet-install.sh
./dotnet-install.sh -version 8.0.303
$ENV:PATH="$HOME/.dotnet:$ENV:PATH"
dotnet tool install --global dotnet-ef --version 8.0.0
git clone https://github.com/Azure/Commercial-Marketplace-SaaS-Accelerator.git --depth 1
cd ./Commercial-Marketplace-SaaS-Accelerator/deployment
.\Upgrade.ps1 -WebAppNamePrefix "PREFIX" -ResourceGroupForDeployment "RSG"

Key Changes

1. Improved String-Between Function:

   • Added null checks for string indices
   • Added try-catch block with detailed error messages
   • Handle cases where end delimiter isn't found

2. Enhanced Connection String Parsing:

   • Support multiple format variations:
     • Data Source= or Server=
     • Initial Catalog= or Database=
     • User Id= or User=
     • Password= or pwd=

3. Better Error Handling:

   • Added try-catch blocks around critical operations
   • Added validation for parsed components
   • Improved error messages with expected formats
   • Added cleanup in finally block

Code Changes

# Before
$Server = String-Between -source $ConnectionString -start "Data Source=" -end ";"
$Database = String-Between -source $ConnectionString -start "Initial Catalog=" -end ";"
$User = String-Between -source $ConnectionString -start "User Id=" -end ";"
$Pass = String-Between -source $ConnectionString -start "Password=" -end ";"

# After
try {
    $Server = String-Between -source $ConnectionString -start "Data Source=" -end ";"
    if (!$Server) { $Server = String-Between -source $ConnectionString -start "Server=" -end ";" }
    
    $Database = String-Between -source $ConnectionString -start "Initial Catalog=" -end ";"
    if (!$Database) { $Database = String-Between -source $ConnectionString -start "Database=" -end ";" }
    
    $User = String-Between -source $ConnectionString -start "User Id=" -end ";"
    if (!$User) { $User = String-Between -source $ConnectionString -start "User=" -end ";" }
    
    $Pass = String-Between -source $ConnectionString -start "Password=" -end ";"
    if (!$Pass) { $Pass = String-Between -source $ConnectionString -start "pwd=" -end ";" }

    if (!$Server -or !$Database -or !$User -or !$Pass) {
        throw "Could not parse all required connection string components"
    }
}
catch {
    Write-Host "Failed to parse connection string. Please verify the connection string format in KeyVault" -ForegroundColor Red
    Write-Host "Expected format: 'Data Source=server;Initial Catalog=database;User Id=user;Password=pass;'" -ForegroundColor Yellow
    throw
}

[DmarshalTU]

@microsoft-github-policy-service agree company="CodeWizard"