Cleanup dummy defaults in pool, settings and probe when unused #1598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshaysngupta
changed the title
sean-jeffrey
approved these changes
Apr 1, 2024
akshaysngupta
added a commit
that referenced
this pull request
Apr 4, 2024
* cleanup unused defaults in pool, settings and probe * fix test yamls * compare with resource name instead of suffix * resource id has resource name * lower case
akshaysngupta
added a commit
that referenced
this pull request
Apr 4, 2024
#1604) * cleanup unused defaults in pool, settings and probe * fix test yamls * compare with resource name instead of suffix * resource id has resource name * lower case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Fixes.Description
AGIC creates dummy backend pool and backend http settings which are used referenced from request routing rule when linked service doesn't exists.
This PR cleans up these dummy resources by doing a post processing on the generated appgw config and finding the dummy resources which are not used and then removing them.
E2E Tests passing:
Fixes
Fixes #1466