-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support modeling existing aiProject in composition #4876
base: main
Are you sure you want to change the base?
Conversation
{{- if .AiProject }} | ||
resource aiProjectRG 'Microsoft.Resources/resourceGroups@2021-04-01' existing = { | ||
scope: subscription() | ||
name: split(aiProjectConnectionString, ';')[2] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the project connection string a fixed ordering?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
{{- if .AiProject }} | ||
{{- if .AiProject.ConnStringFromEnvVar }} | ||
"{{bicepName .AiProject.Name}}ConnectionString": { | ||
"value": "${{`{`}}{{.AiProject.ConnStringFromEnvVar}}{{`}`}}" | ||
}, | ||
{{- end }} | ||
{{- end }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this make sense at all as a preExecExpand
parameter in scaffold.go
as a dynamic parameter values?
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash:
pwsh:
WindowsPowerShell install
MSI install
Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
{{- if .AiFoundryProject }} | ||
output AZURE_AIPROJECT_CONNECTION_STRING string = aiModelsDeploy.outputs.aiFoundryProjectConnectionString | ||
{{- if .AiProject }} | ||
output AZURE_AIPROJECT_CONNECTION_STRING string = aiModelsDeploy.outputs.aiProjectConnectionString |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
output AZURE_AIPROJECT_CONNECTION_STRING string = aiModelsDeploy.outputs.aiProjectConnectionString | |
output AZURE_AI_PROJECT_CONNECTION_STRING string = aiModelsDeploy.outputs.aiProjectConnectionString |
Maybe this looks maybe and closer to #4746
name: '${abbrs.storageStorageAccounts}hub${resourceToken}' | ||
name: '${abbrs.storageStorageAccounts}${resourceToken}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a bad merge, restore hub
to avoid collisions if that makes sense to you
No description provided.