Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env var check for worker runtime in StartHostAction #4198

Closed
wants to merge 2 commits into from

Conversation

Zemfm
Copy link

@Zemfm Zemfm commented Nov 21, 2024

Adds a check to StartHostAction to use the environment variable "FUNCTIONS_WORKER_RUNTIME" if available, before displaying the Wizard Prompt.

This enables setting the runtime through environment variables as was the case in the past.

Issue describing the changes in this PR

resolves #4193

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Note: I was unable to run or write unit tests and only validated manually by running the tool against a function with/without environment variables set:
https://github.com/Azure/azure-functions-core-tools/blob/v4.x/CONTRIBUTING.md#running-the-test-suite

I was able to run the tests and added a unit test. It would be helpful if the link above was updated.

@Zemfm Zemfm requested a review from a team as a code owner November 21, 2024 19:58
@Zemfm
Copy link
Author

Zemfm commented Nov 22, 2024

@microsoft-github-policy-service agree

@aishwaryabh aishwaryabh changed the base branch from v4.x to main November 26, 2024 20:21
@Zemfm
Copy link
Author

Zemfm commented Dec 31, 2024

Any chance this can get looked at? It's been open for over a month now.,,

@liliankasem
Copy link
Member

@Zemfm thank you for contributing. I don't see any reason why you cannot use an environment variable to set the worker runtime locally, however I wanted to do some cleanup here, and have the environment logic somewhere it makes more sense (as part of the init flow for GlobalCoreToolsSettings). Because of this, I have created a new PR that should fix this issue: #4219 and will close this PR. Let me know if you have any questions. Thanks!

@liliankasem liliankasem closed this Jan 7, 2025
@Zemfm Zemfm deleted the zemfm/add-env-var-runtime-support branch January 8, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@4 version broken by a patch release
2 participants